Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pro:search): segment should init only when it's set inactive #1656

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

高级搜索,当激活的segment发生变化时,所有的segment都会被初始化一遍

What is the new behavior?

仅当激活状态的segment被置于非激活状态,类似于blur的时候,才对其进行单独初始化。

Other information

@idux-bot
Copy link

idux-bot bot commented Aug 21, 2023

This preview will be available after the AzureCI is passed.

@sallerli1 sallerli1 force-pushed the fix-segment-state-init-saller branch from a8b25ee to da18d2b Compare August 21, 2023 02:51
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #1656 (3f12fb6) into main (192ca82) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

❗ Current head 3f12fb6 differs from pull request most recent head da18d2b. Consider uploading reports for the commit da18d2b to get more accurate results

@@            Coverage Diff             @@
##             main    #1656      +/-   ##
==========================================
- Coverage   92.59%   92.59%   -0.01%     
==========================================
  Files         345      345              
  Lines       32285    32274      -11     
  Branches     3685     3685              
==========================================
- Hits        29895    29884      -11     
  Misses       2390     2390              
Files Changed Coverage Δ
packages/pro/search/src/ProSearch.tsx 15.89% <50.00%> (-3.71%) ⬇️

@sallerli1 sallerli1 merged commit 6ae11ea into IDuxFE:main Aug 21, 2023
7 checks passed
@sallerli1 sallerli1 deleted the fix-segment-state-init-saller branch July 4, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant