Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk:popper): modify default placement to bottomStart #1785

Merged
merged 1 commit into from
Jan 8, 2024
Merged

fix(cdk:popper): modify default placement to bottomStart #1785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/cdk/popper/__tests__/__snapshots__/popper.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ exports[`usePopper > options > autoAdjust work 2`] = `

exports[`usePopper > options > offset work 1`] = `
"<div id=\\"trigger\\">Trigger</div>
<div id=\\"overlay\\" style=\\"position: absolute; left: 0px; top: 0px;\\" data-popper-reference-hidden=\\"\\" data-popper-placement=\\"top\\">Popper</div>"
<div id=\\"overlay\\" style=\\"position: absolute; left: 0px; top: 0px;\\" data-popper-reference-hidden=\\"\\" data-popper-placement=\\"bottom-start\\">Popper</div>"
`;

exports[`usePopper > options > offset work 2`] = `
"<div id=\\"trigger\\">Trigger</div>
<div id=\\"overlay\\" style=\\"position: absolute; left: 0px; top: 0px;\\" data-popper-reference-hidden=\\"\\" data-popper-placement=\\"top\\">Popper</div>"
<div id=\\"overlay\\" style=\\"position: absolute; left: 0px; top: 0px;\\" data-popper-reference-hidden=\\"\\" data-popper-placement=\\"bottom-start\\">Popper</div>"
`;

exports[`usePopper > options > placement work 1`] = `
Expand Down
2 changes: 1 addition & 1 deletion packages/cdk/popper/docs/Api.zh.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export function usePopper(options?: PopperOptions): PopperInstance
| `delay` | 延迟显示或隐藏的时间 | `number \| [number \| null, number \| null]` | `0` | - | 为数组时，第一个元素是延迟显示的时间，第二个元素是延迟隐藏的时间 |
| `disabled` | 是否禁用浮层 | `boolean` | `false` | - | - |
| `offset` | 浮层相对目标元素的偏移量 | `[number, number]` | `[0, 0]` | - | 第一个元素是水平偏移量，第二个元素是垂直偏移量 |
| `placement` | 浮层的位置 | `PopperPlacement` | `top` | - | - |
| `placement` | 浮层的位置 | `PopperPlacement` | `bottomStart` | - | - |
| `trigger` | 浮层的触发方式 | `PopperTrigger` | `hover` | - | - |
| `visible` | 是否显示浮层 | `boolean` | `false` | - | - |
| `strategy` | 浮层的定位策略 | `'absolute' \| 'fixed'` | `absolute` | - | - |
Expand Down
2 changes: 1 addition & 1 deletion packages/cdk/popper/src/composables/useOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export function usePopperOptions(options: PopperOptions): {
delay: options.delay ?? defaultDelay,
disabled: options.disabled ?? false,
offset: options.offset ?? [0, 0],
placement: options.placement ?? 'top',
placement: options.placement ?? 'bottomStart',
trigger: options.trigger ?? 'hover',
visible: options.visible ?? false,
strategy: options.strategy ?? 'absolute',
Expand Down