Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk:scroll): update scroll blocked style #660

Merged
merged 1 commit into from
Dec 24, 2021
Merged

fix(cdk:scroll): update scroll blocked style #660

merged 1 commit into from
Dec 24, 2021

Conversation

danranVm
Copy link
Member

fix #586

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Dec 23, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #660 (3ea4fdb) into main (efbfda1) will increase coverage by 0.25%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #660      +/-   ##
==========================================
+ Coverage   83.66%   83.92%   +0.25%     
==========================================
  Files         396      396              
  Lines        9897     9907      +10     
  Branches     2273     2277       +4     
==========================================
+ Hits         8280     8314      +34     
+ Misses       1617     1593      -24     
Impacted Files Coverage Δ
...ges/cdk/scroll/src/strategy/blockScrollStrategy.ts 86.66% <94.11%> (+2.66%) ⬆️
packages/components/select/src/types.ts 100.00% <0.00%> (ø)
packages/cdk/scroll/src/utils.ts 85.33% <0.00%> (+32.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efbfda1...3ea4fdb. Read the comment docs.

@danranVm danranVm merged commit 4d7bbff into IDuxFE:main Dec 24, 2021
@danranVm danranVm deleted the fix-cdk-scroll-lock branch December 24, 2021 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant