-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(comp:modal): add padding to padding next icon #701
feat(comp:modal): add padding to padding next icon #701
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## main #701 +/- ##
==========================================
- Coverage 85.33% 85.30% -0.04%
==========================================
Files 396 396
Lines 9945 9948 +3
Branches 2304 2303 -1
==========================================
- Hits 8487 8486 -1
- Misses 1458 1462 +4
Continue to review full report at Codecov.
|
1faac2e
to
657b749
Compare
@@ -59,6 +51,13 @@ export default defineComponent({ | |||
} | |||
return cancelVisible.value ? locale.value.okText : locale.value.justOkText | |||
}) | |||
const okButton = computed<ButtonProps>(() => ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不应该改这里,而是改 ɵFooter, 因为还有其他几个组件的渲染逻辑应该都是一样的,
@modal-body-confirm-color: @color-warning; | ||
@modal-body-info-color: @color-info; | ||
@modal-body-success-color: @color-success; | ||
@modal-body-warning-color: @color-warning; | ||
@modal-body-error-color: @color-error; | ||
|
||
@modal-typed-body-padding: 0 @font-size-lg @font-size-lg @font-size-lg; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@modal-typed-body-padding: 0 @font-size-lg @font-size-lg @font-size-lg; | |
@modal-body-typed-padding: 0 @spacing-xl @spacing-sm; |
a31c4f4
to
c23c445
Compare
BREAKING CHANGE: replaced empty-color variable with more specific ones BREAKING CHANGE: replace empty-font-size variable with more specific ones feat(comp:modal): add body title and content variables to typed modal
change ok button mode to default when there's no cancel button
c23c445
to
07dc559
Compare
add title and content color variables
feat(comp:empty): add color variables
BREAKING CHANGE: replaced empty-color variable with more specific ones
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
modal组件缺少title与content的具体颜色变量
modal组件在icon存在的前提下右侧的cotent缺少右边距
empty组件缺少具体的颜色变量
What is the new behavior?
增加 modal组件的 title color 和 content color的变量
增加modal右侧content的右边距,与icon的左边距一致
empty将empty-color替换成3个具体的颜色变量
Other information