feat(comp:select): add 'overlay' to searchable #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## main #729 +/- ##
==========================================
- Coverage 85.46% 85.46% -0.01%
==========================================
Files 420 421 +1
Lines 10673 10688 +15
Branches 2507 2516 +9
==========================================
+ Hits 9122 9134 +12
- Misses 1551 1554 +3
Continue to review full report at Codecov.
|
danranVm
requested changes
Jan 18, 2022
| const labelRender = rawOption.customLabel ?? 'optionLabel' | ||
| const labelSlot = isString(labelRender) ? slots[labelRender] : labelRender | ||
|
|
||
| return slots.label?.(rawOption) ?? labelSlot?.(rawOption) ?? label |
There was a problem hiding this comment.
Suggested change
| return slots.label?.(rawOption) ?? labelSlot?.(rawOption) ?? label | |
| return labelSlot? labelSlot(rawOption) : label |
| if (isMax) { | ||
| labelNode = slots.maxLabel?.(item.value) ?? label | ||
| } else { | ||
| labelNode = slots.label?.(item.rawOption) ?? rawOption.slots?.default?.() ?? label | ||
| labelNode = slots.label?.(rawOption) ?? renderOptionLabel(slots, rawOption, label) |
There was a problem hiding this comment.
Suggested change
| labelNode = slots.label?.(rawOption) ?? renderOptionLabel(slots, rawOption, label) | |
| labelNode = slots.label ? slots.label(rawOption) : renderOptionLabel(slots, rawOption, label) |
sallerli1
force-pushed
the
feat-select-searchable-saller
branch
from
cc8923a
to
be59d57
Compare
input is now rendered within overlay when searchable is 'overlay' fix(comp:selectable): fix selected options render when using IxOption refactor(comp:selectable): replace slot label with selectedLabel replace slot maxLabel with overflowedLabel
sallerli1
force-pushed
the
feat-select-searchable-saller
branch
from
be59d57
to
d3a6dfe
Compare
danranVm
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
input is now rendered within overlay when searchable is 'overlay'
fix(comp:selectable): fix selected options render when using IxSelectOption
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Other information
抽离label渲染的工具函数 renderOptionLabel