Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp: timeline): rebuild with tsx #803

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

liuzaijiang
Copy link
Contributor

PR Checklist

BREAKING CHANGE:
timeline : position was deprecated, please use placement instead, add both prop
timelineItem: add label and placement props

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Mar 17, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #803 (b25894b) into main (eca22cf) will increase coverage by 0.35%.
The diff coverage is 100.00%.

❗ Current head b25894b differs from pull request most recent head d5941b3. Consider uploading reports for the commit d5941b3 to get more accurate results

@@            Coverage Diff             @@
##             main     #803      +/-   ##
==========================================
+ Coverage   84.00%   84.35%   +0.35%     
==========================================
  Files         466      467       +1     
  Lines       12038    12028      -10     
  Branches     2898     2892       -6     
==========================================
+ Hits        10112    10146      +34     
+ Misses       1926     1882      -44     
Impacted Files Coverage Δ
packages/components/timeline/src/types.ts 100.00% <ø> (ø)
packages/components/timeline/src/Timeline.tsx 100.00% <100.00%> (ø)
packages/components/timeline/src/TimelineItem.tsx 100.00% <100.00%> (ø)
packages/components/timeline/src/token.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eca22cf...d5941b3. Read the comment docs.

@liuzaijiang liuzaijiang force-pushed the comp-refactor-timeline branch 2 times, most recently from 230bde4 to 9f74675 Compare March 17, 2022 09:35
@danranVm danranVm merged commit 8677d61 into IDuxFE:main Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants