Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:carousel): modify onChange params order #863

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

brenner8023
Copy link
Member

@brenner8023 brenner8023 commented Apr 25, 2022

FIX #862

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

onChange入参顺序是prevIndex,nextIndex

What is the new behavior?

onChange入参顺序是nextIndex,prevIndex

Other information

@idux-bot
Copy link

idux-bot bot commented Apr 25, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #863 (c3aaf95) into main (50fb584) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #863   +/-   ##
=======================================
  Coverage   93.50%   93.50%           
=======================================
  Files         658      658           
  Lines       64529    64529           
  Branches     7855     7855           
=======================================
  Hits        60341    60341           
  Misses       4188     4188           
Impacted Files Coverage Δ
...ges/components/carousel/src/composables/useWalk.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50fb584...c3aaf95. Read the comment docs.

@danranVm danranVm merged commit d08b9f3 into IDuxFE:main Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[comp:carousel] onChange的入参顺序期望是nextIndex,prevIndex
2 participants