Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdk:drag-drop): add useDraggable and CdkDraggable #939

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

danranVm
Copy link
Member

@danranVm danranVm commented Jun 6, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Jun 6, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #939 (d4613a5) into main (201106d) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

❗ Current head d4613a5 differs from pull request most recent head 3b411f3. Consider uploading reports for the commit 3b411f3 to get more accurate results

@@            Coverage Diff             @@
##             main     #939      +/-   ##
==========================================
- Coverage   93.24%   93.23%   -0.02%     
==========================================
  Files         682      683       +1     
  Lines       66974    67031      +57     
  Branches     5880     7910    +2030     
==========================================
+ Hits        62453    62498      +45     
- Misses       4521     4533      +12     
Impacted Files Coverage Δ
packages/cdk/resize/src/ResizeObserver.tsx 36.53% <33.33%> (+1.99%) ⬆️
packages/cdk/utils/src/useEventListener.ts 54.90% <54.90%> (ø)
packages/cdk/utils/src/dom.ts 88.96% <70.00%> (+5.09%) ⬆️
packages/cdk/resize/src/types.ts 100.00% <100.00%> (ø)
packages/cdk/resize/src/useResizeObserver.ts 95.12% <100.00%> (ø)
packages/cdk/utils/index.ts 100.00% <100.00%> (ø)
packages/cdk/utils/src/composable.ts 100.00% <100.00%> (ø)
packages/cdk/utils/src/convert.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 201106d...3b411f3. Read the comment docs.

@danranVm danranVm merged commit 7161d96 into IDuxFE:main Jun 6, 2022
@danranVm danranVm deleted the fix-carousel-clone-node branch June 6, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant