Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pro:transfer): fix tree transfer labelKey and getKey functionality both flattened and normal #958

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

sallerli1
Copy link
Contributor

fix(pro:tranfer): fix tree expand when getKey provided

BREAKING CHANGE: TransferBindings now provide getRowKey as ComputedRef

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

  1. flat-target-tree 时,labelKey不起作用
  2. getRowKey提供时,tree的展开失效
  3. children 为空数组时,节点变为禁用状态

What is the new behavior?

修复以上问题

Other information

通过 inject 注入以自定义修改的数据 TransferBindings 提供的 getRowKey 改为计算属性
getRowKey改为使用 components/utils 中的实现

@idux-bot
Copy link

idux-bot bot commented Jun 15, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #958 (38db993) into main (5fffb9b) will increase coverage by 0.00%.
The diff coverage is 98.73%.

@@           Coverage Diff           @@
##             main     #958   +/-   ##
=======================================
  Coverage   92.76%   92.76%           
=======================================
  Files         692      691    -1     
  Lines       67811    67853   +42     
  Branches     7931     7929    -2     
=======================================
+ Hits        62904    62947   +43     
+ Misses       4907     4906    -1     
Impacted Files Coverage Δ
.../transfer/src/composables/useTransferTableProps.ts 81.25% <83.33%> (ø)
...kages/pro/transfer/src/content/ProTransferList.tsx 92.38% <85.71%> (-1.74%) ⬇️
...ents/_private/checkable-list/src/CheckableList.tsx 93.60% <100.00%> (+0.05%) ⬆️
...es/components/_private/checkable-list/src/types.ts 100.00% <100.00%> (ø)
packages/components/transfer/src/Transfer.tsx 100.00% <100.00%> (ø)
...ts/transfer/src/composables/useTransferBindings.ts 100.00% <100.00%> (ø)
...onents/transfer/src/composables/useTransferData.ts 99.47% <100.00%> (-0.01%) ⬇️
...nsfer/src/composables/useTransferDataStrategies.ts 100.00% <100.00%> (ø)
.../transfer/src/composables/useTransferOperations.ts 93.18% <100.00%> (-0.64%) ⬇️
.../components/transfer/src/list/TransferListBody.tsx 94.49% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fffb9b...38db993. Read the comment docs.

@sallerli1 sallerli1 changed the title fix(pro:transfer): tree transfer labelKey and getKey functionality both flattened and normal fix(pro:transfer): fix tree transfer labelKey and getKey functionality both flattened and normal Jun 15, 2022
fix(pro:tranfer): fix tree expand when getKey provided

BREAKING CHANGE: TransferBindings provide getKey as ComputedRef instead of getRowKey
@danranVm danranVm merged commit 8319ac0 into IDuxFE:main Jun 15, 2022
@sallerli1 sallerli1 deleted the fix-transfer-saller branch February 20, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants