Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unnecessary IxPropTypes usage #992

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

What is the new behavior?

去掉不必要的 IxPropTypes使用

Other information

@idux-bot
Copy link

idux-bot bot commented Jul 1, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #992 (9b594ad) into main (310360a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##             main     #992    +/-   ##
========================================
  Coverage   94.47%   94.48%            
========================================
  Files         305      305            
  Lines       28134    28705   +571     
  Branches     3488     3476    -12     
========================================
+ Hits        26580    27121   +541     
- Misses       1554     1584    +30     
Impacted Files Coverage Δ
...mponents/_private/collapse-transition/src/types.ts 100.00% <100.00%> (ø)
packages/components/_private/input/src/types.ts 100.00% <100.00%> (ø)
packages/components/_private/loading/src/types.ts 100.00% <100.00%> (ø)
packages/components/_private/mask/src/types.ts 100.00% <100.00%> (ø)
packages/components/_private/overflow/src/types.ts 100.00% <100.00%> (ø)
packages/components/_private/overlay/src/types.ts 100.00% <100.00%> (ø)
packages/components/affix/src/types.ts 100.00% <100.00%> (ø)
packages/components/alert/src/types.ts 100.00% <100.00%> (ø)
packages/components/anchor/src/types.ts 100.00% <100.00%> (ø)
packages/components/avatar/src/types.ts 100.00% <100.00%> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 310360a...9b594ad. Read the comment docs.

@danranVm danranVm merged commit 05f22f3 into IDuxFE:main Jul 1, 2022
@sallerli1 sallerli1 deleted the fix-remove-Ixproptypes-saller branch February 20, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants