Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added back button in MainActivity #39

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Added back button in MainActivity #39

wants to merge 7 commits into from

Conversation

PranavVyas20
Copy link

@PranavVyas20 PranavVyas20 commented Oct 2, 2021 •
edited

  • Added a back button to navigate to the mainActivity, color of the button adjusts according to the layout background.
  • Removed onClickListener from the city_name TextView
  • Minor adjustments in UI

Here are the screenshots:

ss1
ss2

@jazxii
Copy link
Collaborator

jazxii commented Oct 2, 2021

Hey @PranavVyas20 , Kindly don't commit the .idea and .gradle files. Revert it back for your pull request to be accepted.

Ishan-001
Ishan-001 requested changes Oct 3, 2021
View reviewed changes
Copy link
Member

@Ishan-001 Ishan-001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly leave the '.idea files as they are. Rest is LGTM!!

PranavVyas20
PranavVyas20 commented Oct 3, 2021
View reviewed changes
Copy link
Author

@PranavVyas20 PranavVyas20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly review the changes

@Ishan-001
Copy link
Member

Kindly restore the 'runConfigurations.xml' file. Then its gtg.

@PranavVyas20
Copy link
Author

PranavVyas20 commented Oct 3, 2021 •
edited

Kindly restore the 'runConfigurations.xml' file. Then its gtg.

It was deleted in this PR, so should I restore it again ? - 7799daf

@ShivVIT2019
Copy link

Can i contribute or is issue being resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ishan-001 Ishan-001 Ishan-001 approved these changes

@Jatin887 Jatin887 Awaiting requested review from Jatin887

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PranavVyas20 @jazxii @Ishan-001 @ShivVIT2019