Zahed Review (IESG)

I-D-vpn-common/draft-ietf-opsawg-vpn-common.xml

@@ -559,11 +559,20 @@
               protocol can be indicated in the 'protocol' data node under
               'l3', but only TCP and UDP specific match criteria are
               elaborated in this version as these protocols are widely used in
-              the context of VPN services. Augmentations can be considered in
-              the future to add other Layer 4 specific data nodes (e.g.,
-              Stream Control Transmission Protocol <xref
-              target="RFC4960"></xref>), if needed.<figure align="center"
-                  anchor="qos" title="QoS Classification Subtree">
+              the context of VPN services. Future revisions can be considered
+              to add other Layer 4 specific parameters (e.g., Stream Control
+              Transmission Protocol <xref target="RFC4960"></xref>), if
+              needed. <vspace blankLines="1" />Some transport protocols use
+              existing protocols (e.g., TCP or UDP) as substrate. The match
+              criteria for such protocols may rely upon the 'protocol' under
+              'l3', TCP/UDP match criteria shown in <xref
+              target="qos"></xref>, part of the TCP/UDP payload, or a
+              combination thereof. This version of the module does not support
+              such advanced match criteria. Future revisions of the module may
+              consider adding match criteria based on the transport protocol
+              payload (e.g., by means of a bitmask match). <figure
+                  align="center" anchor="qos"
+                  title="QoS Classification Subtree">
                   <artwork align="center"><![CDATA[  grouping qos-classification-policy
     +-- rule* [id]
        +-- id?                        string
@@ -2503,10 +2512,10 @@ module ietf-vpn-common {
   grouping underlay-transport {
     description
       "This grouping defines the type of underlay transport for the
-       VPN service. It can include an identifier to an abstract
-       transport instance to which the VPN is grafted or indicate a
-       technical implementation that is expressed as an ordered list
-       of protocols.";
+       VPN service or how that underlay is set. It can include an 
+       identifier to an abstract transport instance to which the VPN
+       is grafted or indicate a technical implementation that is 
+       expressed as an ordered list of protocols.";
     choice type {
       description
         "A choice based on the type of underlay transport
@@ -2967,8 +2976,8 @@ module ietf-vpn-common {
 
       <t>Special thanks to Robert Wilton for the AD review.</t>
 
-      <t>Thanks to Roman Danyliw, Lars Eagert, Warren Kumari, and Erik Kline
-      for the IESG review.</t>
+      <t>Thanks to Roman Danyliw, Lars Eagert, Warren Kumari, Erik Kline, and
+      Zaheduzzaman Sarker for the IESG review.</t>
     </section>
 
     <section title="Contributors">