micropost create controller, views, infinite-scroll, add stimulus.js #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| body { | ||
| background-color: $background-color; |
There was a problem hiding this comment.
фон для контента, в colors.scss
There was a problem hiding this comment.
що з форматуванням
| = micropost.title | ||
| hr/ | ||
| = image_tag micropost.image.url, class: "img-fluid" if micropost.image? | ||
| /img.img-fluid src="https://i.imgur.com/xhzhaGA.jpg" / |
There was a problem hiding this comment.
нащо цей комент тут
There was a problem hiding this comment.
видалю, тестив просто
| = link_to 'New', new_account_micropost_path, class: 'btn btn-outline-success' | ||
| div data-controller="infinite-scroll" data-action="scroll@window->infinite-scroll#scroll" | ||
| div data-infinite-scroll-target="entries" | ||
| = render 'account/microposts/microposts' |
There was a problem hiding this comment.
паршали немають мати інстанс змінних, туди передаватись має
| format.html | ||
| format.json { | ||
| render json: { entries: render_to_string(partial: "microposts.html.slim", formats: [:html]), | ||
| pagination: render_to_string(partial: "paginate.html.slim") } |
There was a problem hiding this comment.
а тут не треба вказувати формат як вище?
igorkasyanchuk
approved these changes
Jun 18, 2021
mdotvasylenchuk
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admin create microposts, micropost views, infinitescroll
Changes description
add microposts controller
add micropost views
admin can create, delete micropost (with ajax)
infinite-scroll for microposts feed
update seeds
update factory
Screnshots of the added pages
admin view:
view mobile:
user view:
Check list: