Merge pull request #172 from IFCA/fix-msprt-fit

Add missing on_fit_end in mSPRT

frouros/callbacks/base.py

@@ -55,13 +55,13 @@ def set_detector(self, detector) -> None:
     #         )
     #     self._detector = value
 
-    def on_fit_start(self) -> None:
+    def on_fit_start(self, **kwargs) -> None:
         """On fit start method."""
 
-    def on_fit_end(self) -> None:
+    def on_fit_end(self, **kwargs) -> None:
         """On fit end method."""
 
-    def on_drift_detected(self) -> None:
+    def on_drift_detected(self, **kwargs) -> None:
         """On drift detected method."""
 
     @abc.abstractmethod

frouros/callbacks/streaming/msprt.py

@@ -21,7 +21,7 @@ class mSPRT(StreamingCallback):  # noqa: N801 # pylint: disable=invalid-name
 
     def __init__(
         self,
-        alpha: float = 0.05,
+        alpha: float,
         sigma: float = 1.0,
         tau: Optional[float] = None,
         truncation: int = 1,
@@ -97,6 +97,10 @@ def tau(self, value: Optional[float]) -> None:
             raise TypeError("tau must be a float or None")
         self._tau = value
 
+    def on_fit_end(self, **kwargs) -> None:
+        """On fit end method."""
+        self.incremental_mean.num_values = len(kwargs["X"])
+
     def on_update_end(self, value: Union[int, float], **kwargs) -> None:
         """On update end method.
 

frouros/detectors/data_drift/base.py

@@ -188,7 +188,7 @@ def fit(self, X: np.ndarray, **kwargs) -> Dict[str, Any]:  # noqa: N803
             callback.on_fit_start()
         self._fit(X=X, **kwargs)
         for callback in self.callbacks:  # type: ignore
-            callback.on_fit_end()
+            callback.on_fit_end(X=X, **kwargs)
 
         logs = self._get_callbacks_logs()
         return logs

frouros/tests/integration/test_callback.py

@@ -242,7 +242,7 @@ def test_streaming_warning_samples_buffer_on_concept_drift(
     " expected_p_value,"
     " expected_likelihood",
     [
-        (MMDStreaming, 70, 0.3622854, 0.0324733, 30.79452443),
+        (MMDStreaming, 40, 0.08821576, 0.00494882, 202.06836342),
     ],
 )
 def test_streaming_msprt_multivariate_different_distribution(

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "frouros"
-version = "0.2.4"
+version = "0.2.5"
 description = "A Python library for drift detection in Machine Learning problems"
 authors = [
     {name = "Jaime Céspedes Sisniega", email = "cespedes@ifca.unican.es"}