Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent picking an ifcSpace or IfcAnnotation if it wasn't generated #139

Open
agviegas opened this issue May 31, 2022 · 4 comments
Open

Comments

@agviegas
Copy link
Collaborator

agviegas commented May 31, 2022

Items that are not generated (ifcspaces sometimes, ifcannotation always) show up in the spatial tree and can be selected. Because if the camera is animated to go to the selection, and the ifcspace doesn't exist, the camera goes to infinity and breaks.

https://github.com/IFCjs/ifcjs-crash-course/tree/main/exercises/CSS/Flexbox

@agviegas agviegas changed the title Prevent picking an ifcSpace if it wasn't generated Prevent picking an ifcSpace or IfcAnnotation if it wasn't generated May 31, 2022
@horfee
Copy link

horfee commented Sep 26, 2022

Hi, Same problem happens if selecting from Structure tree the IfcProject, IfcSite, IfcSpace, IfcBuildingStorey, and I assume some others elements...
Here you can have an example : https://discord.com/channels/799990228336115742/800000126998675457/1023227872309162064

@horfee
Copy link

horfee commented Sep 27, 2022

I found a way to prevent this behavior :

const props = await this.IFC.getProperties(modelID,expressID, false, true);
if (  props.Representation ) {
    this.IFC.selector.pickIfcItemsByID(modelID, [expressID], true);
}

@pbbr
Copy link

pbbr commented May 1, 2023

Is there a way to generate IfcAnnotation? This is a common case that additional infos were placed as annotations in a model. What do you think?

@agviegas
Copy link
Collaborator Author

agviegas commented May 2, 2023

@pbbr here's an issue to address that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants