-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GetLine always returns the first LineID if its expressId not exist #224
Comments
::take |
🟢🟢🟢
Hi, @aka-blackboots! Thanks for taking this bounty! The due date is November 5, 2022 UTC. If you need to submit some pull requests (PR) to complete the tasks, make sure that the last and only the last PR has a title that either starts with the bounty ID or is exactly the same as the bounty name. After the PR is merged, this bounty’s status will automatically changed to done. If you do not need to make a PR, tell the manager @agviegas to run Good luck! |
::drop |
🟢🟢🟢
Hi, @aka-blackboots! Thanks for giving it a try! It’s now once again available for anyone to take. |
::take |
🟢🟢🟢
Hi, @BSchafer01! Thanks for taking this bounty! The due date is November 17, 2022 UTC. If you need to submit some pull requests (PR) to complete the tasks, make sure that the last and only the last PR has a title that either starts with the bounty ID or is exactly the same as the bounty name. After the PR is merged, this bounty’s status will automatically changed to done. If you do not need to make a PR, tell the manager @agviegas to run Good luck! |
Added a validation check of the ExpressID to ensure it is in the IFC file checking for omitted intermediate ExpressIDs and returns an undefined value if the ExpressID doesn't exist to address ThatOpen#224
#224 GetLine always returns the first LineID if its expressId not exist
::done |
🟢🟢🟢
Hi, @BSchafer01! Thanks for your contributions! Please submit an expense to IFC.js Open Collective. Then, tell us the invoice number via the |
::expense::104189 |
🔴🔴🔴
Hi, @BSchafer01! We cannot find a new expense with that invoice number. Please re-check the invoice number and re-send the command using the correct one. |
Hi @agviegas I've messed up the flow of the automation I believe. The expense has already been approved. I didn't use the "done" command until the expense was approved on Open Collective. Sorry about the confusion |
It's ok! |
Hi there,
I found an issue at
GetLine
( web-api-browser.js line 54518):GetLine
returns always returns the first LineId when its expressID not exists . This case was happened when I tried to load an IFC that it had some missing relations (Is a not well exported IFC of course).From my point of view I think that, the normal behaviour, it should be to throw an error or return undefined value.
Cheers and I'm very thankful to have this great piece of software in the community :-)
The text was updated successfully, but these errors were encountered: