Add View all source #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roshni73
force-pushed
the
feature/source-feeds
branch
2 times, most recently
from
b789b5e
to
e0d3bc4
Compare
roshni73
force-pushed
the
feature/source-feeds
branch
3 times, most recently
from
a81147e
to
7b43353
Compare
barshathakuri
requested changes
Apr 12, 2024
| border-radius: var(--go-ui-border-radius-lg); | ||
| box-shadow: var(--go-ui-box-shadow-md); | ||
| padding: var(--go-ui-spacing-md) var(--go-ui-spacing-lg); | ||
| width: 613px; |
There was a problem hiding this comment.
dont's use px for width
Comment on lines
20
to
22
| gap: var(--go-ui-spacing-sm) var(--go-ui-spacing-lg); | ||
| width: 208px; | ||
| height:142px; |
There was a problem hiding this comment.
Don't use px for height and width.
src/views/ViewAllSource/i18n.json
Outdated
| { | ||
| "namespace": "viewAllSource", | ||
| "strings": { | ||
| "sourceFeedsTitle":"Sourc Feeds" |
There was a problem hiding this comment.
Suggested change
| "sourceFeedsTitle":"Sourc Feeds" | |
| "sourceFeedsTitle":"Source Feeds" |
src/views/ViewAllSource/index.tsx
Outdated
| { | ||
| variables: { | ||
| pagination: { | ||
| limit: 10, |
There was a problem hiding this comment.
Use a variable for Limit size
src/views/ViewAllSource/index.tsx
Outdated
Comment on lines
65
to
66
| // FIX ME : | ||
| lastUpdated: 'last updated :2000-22-24', |
There was a problem hiding this comment.
Lets remove this for now.
roshni73
force-pushed
the
feature/source-feeds
branch
from
7b43353
to
09c81ae
Compare
barshathakuri
force-pushed
the
feature/source-feeds
branch
from
09c81ae
to
f8b290d
Compare
barshathakuri
force-pushed
the
feature/source-feeds
branch
from
f8b290d
to
4211c22
Compare
barshathakuri
force-pushed
the
feature/source-feeds
branch
from
4211c22
to
c3a892c
Compare
frozenhelium
force-pushed
the
feature/source-feeds
branch
from
add27be
to
fadd1f6
Compare
- Add query to display the source details in view all source - Fix source feed styling - Add source pagination
frozenhelium
force-pushed
the
feature/source-feeds
branch
from
fadd1f6
to
7b8121e
Compare
frozenhelium
force-pushed
the
feature/source-feeds
branch
from
f93cca5
to
0dcaab7
Compare
frozenhelium
force-pushed
the
feature/source-feeds
branch
from
0dcaab7
to
74a9fce
Compare
barshathakuri
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses:
Changes
This PR doesn't introduce:
console.logmeant for debugging