Don't assume portrait orientation if UIDeviceOrientation is FaceUp/FaceDown #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ait — instead, use statusBarOrientation
…n front/back camera selection
…sh (Apple Watch case)
Update interface to return error if no photo will be taken
This reverts commit 7b7a916.
Add a notification that UI can catch when interruptions occur
- Requesting Cam auth changed: now checked on init, but only notified when you attempt to take an action like takePhoto - _setupSession is synchronous again - Image processing moved to high priority queue
…stop normalizing them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the deviceOrientation is faceUp or faceDown, then before this change the code assumes this means portrait orientation. This doesn't work for my iPad app, because often a faceUp iPad is in landscape orientation.
This pull request changes the behavior only for faceUp/Down orientation: the statusBar orientation is used instead. This means that faceUp-Landscape and faceUp-Portrait are both supported.