Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[del] onStart option and feature #48

Merged
merged 2 commits into from
Mar 13, 2023
Merged

[del] onStart option and feature #48

merged 2 commits into from
Mar 13, 2023

Conversation

lgrd
Copy link
Collaborator

@lgrd lgrd commented Mar 13, 2023

onStart is an option and a feature inside the administrator configuration. It allows a service to be configured but not load at the beginning. But it is not really useful and the code is more complex. Deleting this feature allows a simpler code. It is still possible to load an administrator withtout any services and create them later.

@lgrd lgrd added the refactor Related to code refactoring label Mar 13, 2023
@lgrd lgrd self-assigned this Mar 13, 2023
@lgrd lgrd mentioned this pull request Mar 13, 2023
8 tasks
jmkerloch
jmkerloch previously approved these changes Mar 13, 2023
Copy link
Contributor

@jmkerloch jmkerloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment for the version but LGTM.

changelog.md Outdated Show resolved Hide resolved
@lgrd lgrd merged commit e6b9331 into develop Mar 13, 2023
@lgrd lgrd deleted the del/onStart branch March 13, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Related to code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants