Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] add projection parameters inside get route #71

Merged
merged 1 commit into from
May 9, 2023
Merged

[feat] add projection parameters inside get route #71

merged 1 commit into from
May 9, 2023

Conversation

lgrd
Copy link
Collaborator

@lgrd lgrd commented Apr 6, 2023

Close #64

@lgrd lgrd requested review from azarz and jmkerloch April 6, 2023 16:00
@lgrd lgrd self-assigned this Apr 6, 2023
azarz
azarz reviewed Apr 6, 2023
View reviewed changes
Copy link
Member

@azarz azarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jmkerloch
jmkerloch previously approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@jmkerloch jmkerloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@lgrd lgrd marked this pull request as draft May 5, 2023 15:04
@lgrd lgrd force-pushed the feat/get_projection_params branch from 8523854 to 907d19b Compare May 5, 2023 15:04
@lgrd lgrd marked this pull request as ready for review May 5, 2023 15:08
@lgrd lgrd requested a review from azarz May 5, 2023 15:08
jmkerloch
jmkerloch approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@jmkerloch jmkerloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me ! 👍

@lgrd lgrd merged commit b51db66 into develop May 9, 2023
3 checks passed
@lgrd lgrd deleted the feat/get_projection_params branch May 9, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azarz azarz azarz approved these changes

@jmkerloch jmkerloch jmkerloch approved these changes

Assignees

@lgrd lgrd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] GET /services/{service}/projections/{projection} implementation (2/2)
3 participants
@lgrd @azarz @jmkerloch