IGVF-32 Update mobile header #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 23, 2022 09:50
…le, and logo and hamburger menu to white on mobile. Change the Tailwind CSS config to use “brand-color” instead of “logo-color.” Converted Tailwind CSS config to use a class for dark mode, and added code to sense the user changing between dark and light mode. Starting to use CSS variables for theming. Will work on theming in the next commit in this branch. Extract code to manage dark mode Tailwind CSS classes to a library. Add tests and mocks for the dark-mode manager. Implement Jest tests for OS dark mode. Remove forgotten .only() to test for more coverage. Update package.json for the latest versions of packages. Update comments from this branch’s changes.
Add mobile menu navigation.
Add Cypress tests for the mobile menu.
Correct Cypress mobile menu test.
Only include .container class beyond mobile so that the navigation header can span across the entire viewport width.
Use light and dark themes in Tailwind configuration.
Change dark highlight color
Update navigation colors for mobile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the mobile header to be more clear to users. I also switched Tailwind CSS to use the darkMode “class” mode instead of “media” mode so that we can do more auto-switching of styles between dark and light modes.