IGVF-61 React 18 upgrade #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 31, 2022 13:55
Upgrade non-breaking outdated npm packages.
Upgrade prettier to 2.6.1 and fix its semver.
Update react, react-dom, and RTL.
Remove the user-event testing library as its click() method seems not to work after its upgrade to 14.0.3. For now I use the older fireEvent instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also updated all outdated packages. This caused an issue with the RTL user-event library being unable to perform clicks. I have converted these to use the older
fireEventmethod, and have (for now) removed the RTL user-event nom package.