Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misplaced tour if target element has overflow:auto CSS #50

Open
mlocati opened this issue Apr 6, 2020 · 2 comments
Open

Misplaced tour if target element has overflow:auto CSS #50

mlocati opened this issue Apr 6, 2020 · 2 comments

Comments

@mlocati
Copy link

mlocati commented Apr 6, 2020

Consider this sample:

<div id="panel">
    <div id="target">
      target
  </div>
</div>

where #panel has position: absolute and overflow: auto; CSS styles.
In this case, tours associated to #target are wrongly placed.

See for example https://jsfiddle.net/LocatiM/yr5epw9t/8/ (which has a tour with placement: 'right'):

immagine

If #panel doesn't have overflow: auto, the result is (correctly) this:

immagine

mlocati added a commit to mlocati/concrete5-bedrock that referenced this issue Apr 8, 2020
mlocati added a commit to mlocati/concrete5-bedrock that referenced this issue Apr 8, 2020
mlocati added a commit to mlocati/concrete5-bedrock that referenced this issue Apr 9, 2020
@IGreatlyDislikeJavascript
Copy link
Owner

Thank you for the report. Appreciate your patience until I can look at this (and the other open issues and pull). Like everyone, coronavirus has caused major disruption for me. Hoping to get back on Tourist code in the next few weeks. Thanks, and stay safe.

@mlocati
Copy link
Author

mlocati commented Apr 10, 2020

Thanks to you! I fully understand: I'm living in Northern Italy, and in the last 30 days I went out only 3 times...
Stay safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants