forked from inuits/mqttgateway
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sparkpluggw key value engine #6
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ober37
reviewed
Apr 7, 2020
ober37
reviewed
Apr 7, 2020
ober37
reviewed
Apr 7, 2020
ober37
reviewed
Apr 7, 2020
ober37
reviewed
Apr 7, 2020
ober37
reviewed
Apr 7, 2020
ober37
reviewed
Apr 7, 2020
ober37
reviewed
Apr 7, 2020
ober37
reviewed
Apr 7, 2020
ober37
reviewed
Apr 7, 2020
ober37
reviewed
Apr 7, 2020
ober37
reviewed
Apr 7, 2020
ober37
requested changes
Apr 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a number of inline comments
chaets
commented
Apr 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the requested changes, its ready to review and merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will create an ability to sparkpluggw to add dynamically key value pair attached with metrics with different or same name in different folder archtecture
updating metric: name(ess_seq_test) value(1555) labels([sp_namespace sp_group_id sp_edge_node_id sp_device_id]) values(map[sp_device_id:sunrise:z0:c1:ess:1:service:1 sp_edge_node_id:sunrise:_:c1:igw:1:service:1 sp_group_id:v2:prod:ess sp_namespace: XXXXX]) siteLabelValues(map[sp_device_id:sunrise:z0:c1:ess:1:service:1 sp_edge_node_id:sunrise:_:c1:igw:1:service:1 sp_group_id:v2:prod:ess sp_namespace: XXXXX])
Creating new metric name and timeseries: name(ess_zones_total) value(1) labels([sp_namespace sp_group_id sp_edge_node_id sp_device_id comptest]) values(map[comptest:1 sp_device_id:sunrise:z0:c1:ess:1:service:1 sp_edge_node_id:sunrise:_:c1:igw:1:service:1 sp_group_id:v2:prod:ess sp_namespace:XXXXX]) siteLabelValues(map[sp_device_id:sunrise:z0:c1:ess:1:service:1 sp_edge_node_id:sunrise:_:c1:igw:1:service:1 sp_group_id:v2:prod:ess sp_namespace:XXXXX])