Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparkpluggw key value engine #6

Merged
merged 12 commits into from
Apr 8, 2020
Merged

Conversation

chaets
Copy link

@chaets chaets commented Apr 6, 2020

This will create an ability to sparkpluggw to add dynamically key value pair attached with metrics with different or same name in different folder archtecture

updating metric: name(ess_seq_test) value(1555) labels([sp_namespace sp_group_id sp_edge_node_id sp_device_id]) values(map[sp_device_id:sunrise:z0:c1:ess:1:service:1 sp_edge_node_id:sunrise:_:c1:igw:1:service:1 sp_group_id:v2:prod:ess sp_namespace: XXXXX]) siteLabelValues(map[sp_device_id:sunrise:z0:c1:ess:1:service:1 sp_edge_node_id:sunrise:_:c1:igw:1:service:1 sp_group_id:v2:prod:ess sp_namespace: XXXXX])

Creating new metric name and timeseries: name(ess_zones_total) value(1) labels([sp_namespace sp_group_id sp_edge_node_id sp_device_id comptest]) values(map[comptest:1 sp_device_id:sunrise:z0:c1:ess:1:service:1 sp_edge_node_id:sunrise:_:c1:igw:1:service:1 sp_group_id:v2:prod:ess sp_namespace:XXXXX]) siteLabelValues(map[sp_device_id:sunrise:z0:c1:ess:1:service:1 sp_edge_node_id:sunrise:_:c1:igw:1:service:1 sp_group_id:v2:prod:ess sp_namespace:XXXXX])

@ober37 ober37 self-requested a review April 7, 2020 13:31
exporter.go Outdated Show resolved Hide resolved
exporter.go Outdated Show resolved Hide resolved
exporter.go Outdated Show resolved Hide resolved
exporter.go Outdated Show resolved Hide resolved
exporter.go Outdated Show resolved Hide resolved
exporter.go Outdated Show resolved Hide resolved
utilities.go Outdated Show resolved Hide resolved
utilities.go Outdated Show resolved Hide resolved
utilities.go Outdated Show resolved Hide resolved
utilities.go Outdated Show resolved Hide resolved
utilities.go Outdated Show resolved Hide resolved
utilities.go Outdated Show resolved Hide resolved
Copy link

@ober37 ober37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a number of inline comments

Copy link
Author

@chaets chaets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the requested changes, its ready to review and merge

@chaets chaets requested a review from ober37 April 8, 2020 00:54
@ober37 ober37 merged commit bce2aa0 into master Apr 8, 2020
@ober37 ober37 deleted the sparkpluggw-key-value-engine branch April 8, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants