Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Breadcrumb API #20

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Update Breadcrumb API #20

merged 4 commits into from
Jan 8, 2024

Conversation

Littletonconnor
Copy link

Overview

Fixes #19 by exposing BreadcrumbLink since React aria's Link component no longer clones children.

Example

CleanShot 2024-01-06 at 13 17 26

  • There's no longer duplicate anchor elements.

Docs

CleanShot 2024-01-06 at 13 17 05@2x

  • I tried to keep the docs light and just point to the React aria component docs instead. I wasn't sure where the best place to put this was but I tried to also follow other conventions I saw used on different components like Input

@IHIutch IHIutch changed the base branch from main to dev January 8, 2024 04:34
@IHIutch
Copy link
Owner

IHIutch commented Jan 8, 2024

This is great, thank you!

@IHIutch IHIutch merged commit df6bf56 into IHIutch:dev Jan 8, 2024
1 of 3 checks passed
@Littletonconnor Littletonconnor deleted the fix-breadcrumbs branch January 8, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breadcrumbs have duplicate role=link
2 participants
@Littletonconnor @IHIutch