Fix up complete_reply messages (#8). #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason that aavogt's complete_reply messages were not showing up is because the "Messagin in IPython" documentation is missing a field for the complete_reply messages. There needs to be a "matched_text" field which contains the part of the line on which completions were computed. I have added that field and it seems to work now. FYI, I figured this out because tab completion on the notebook was raising javascript errors in the browser. For future reference, this could be a useful thing to check if something in the notebook is not working.
|
looks good |
gibiansky
added a commit
that referenced
this pull request
Nov 4, 2013
Fix up complete_reply messages (#8).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason that aavogt's complete_reply messages were not showing up is because the "Messagin in IPython" documentation is missing a field for the complete_reply messages. There needs to be a "matched_text" field which contains the part of the line on which completions were computed. I have added that field and it seems to work now.
FYI, I figured this out because tab completion on the notebook was raising javascript errors in the browser. For future reference, this could be a useful thing to check if something in the notebook is not working.