1332 selectors #1500
Merged
1332 selectors #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomcrane
previously approved these changes
Mar 12, 2018
zimeon
reviewed
Mar 12, 2018
source/api/presentation/3.0/index.md
Outdated
| @@ -737,17 +737,31 @@ The value _MUST_ be an array of JSON objects. Each item _MUST_ have the `id` and | |||
|
|
|||
| A link from this Manifest or Range, to a Canvas, or part of a Canvas, that is contained within it. The reference to part of a Canvas is handled in the same way that Ranges reference parts of Canvases. When processing this relationship, a client _SHOULD_ advance to the specified Canvas, or specified segment of the Canvas, when beginning navigation through the Range. This allows the client to begin with the first Canvas that contains interesting content rather than requiring the user to manually navigate to find it. | |||
|
|
|||
| The value _MUST_ be a JSON object, which _MUST_ have the `id` and `type` properties. The object _MUST_ be either a Canvas, or a Specific Resource with a Selector and a `source` property where the value is a Canvas. | |||
| The value _MUST_ be a JSON object, which _MUST_ have the `id` and `type` properties. The object _MUST_ be either a Canvas (example 1), or a Specific Resource with a Selector and a `source` property where the value is a Canvas (example 2). | |||
There was a problem hiding this comment.
Since the examples aren't numbered, should we say "first example below" and "second example below" instead of "example 1" etc. ?
zimeon
previously approved these changes
Mar 12, 2018
zimeon
previously approved these changes
Mar 12, 2018
mikeapp
previously approved these changes
Mar 13, 2018
jpstroop
previously approved these changes
Mar 13, 2018
zimeon
dismissed stale reviews from jpstroop, mikeapp, and themself
via
c382746
zimeon
approved these changes
Mar 13, 2018
tomcrane
approved these changes
Mar 14, 2018
|
🕐 🕑 🕒 ... |
mikeapp
approved these changes
Mar 18, 2018
This was referenced Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #953, #1332, #1338, #1386, #1387.