Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image preferredFormats #1816

Merged
merged 2 commits into from
May 9, 2019
Merged

Image preferredFormats #1816

merged 2 commits into from
May 9, 2019

Conversation

mikeapp
Copy link
Member

@mikeapp mikeapp commented Apr 16, 2019

Adding preferredFormats to Image API.

azaroth42
azaroth42 previously approved these changes Apr 16, 2019
View reviewed changes
Copy link
Member

@azaroth42 azaroth42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but there will be conflicts with the other PRs

@azaroth42 azaroth42 added normative Ready-for-TRC Normative changes ready for TRC review labels Apr 16, 2019
zimeon
zimeon previously approved these changes Apr 16, 2019
View reviewed changes
Copy link
Member

@zimeon zimeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and well done for getting the two 5.7 links, I don't see others that would be affected)

@mikeapp mikeapp mentioned this pull request Apr 16, 2019
Open
@mikeapp mikeapp changed the title [TRC DNM WIP] Image preferredFormats [TRC DNM] Image preferredFormats Apr 17, 2019
tomcrane
tomcrane reviewed Apr 17, 2019
View reviewed changes
source/api/image/3.0/index.md
@@ -846,6 +855,7 @@ The following shows an image information response including all of the required
}
],
"rights": "http://rightsstatements.org/vocab/InC-EDU/1.0/",
"preferredFormats": [ "png", "gif"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very minor point - we could use webp rather than (or as well as) gif in the example... [ "webp", "png" ]

tomcrane
tomcrane previously approved these changes Apr 17, 2019
View reviewed changes
jpstroop
jpstroop previously approved these changes Apr 17, 2019
View reviewed changes
@tomcrane tomcrane dismissed stale reviews from jpstroop, zimeon, azaroth42, and themself via a610717 April 18, 2019 11:42
@tomcrane tomcrane self-requested a review April 18, 2019 11:44
@tomcrane
Copy link
Contributor

Approved, but there will be conflicts with the other PRs

Conflicts should now be fixed

@zimeon zimeon mentioned this pull request May 9, 2019
Closed
@zimeon zimeon changed the title [TRC DNM] Image preferredFormats Image preferredFormats May 9, 2019
@zimeon zimeon added Approved-by-TRC Issue has been approved by the TRC and removed Ready-for-TRC Normative changes ready for TRC review labels May 9, 2019
@azaroth42 azaroth42 merged commit c3cd153 into image-prezi-rc2 May 9, 2019
@zimeon zimeon deleted the 1786_image_preferredFormats_prop branch May 9, 2019 18:36
@eroux eroux mentioned this pull request May 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimeon zimeon zimeon approved these changes

@azaroth42 azaroth42 azaroth42 approved these changes

@jpstroop jpstroop jpstroop approved these changes

@tomcrane tomcrane tomcrane approved these changes

Assignees

@mikeapp mikeapp

Labels
Approved-by-TRC Issue has been approved by the TRC normative
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mikeapp @tomcrane @zimeon @azaroth42 @jpstroop