Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate heading, combine Nectar, Bloom and Clover, add Tropiiify #431

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

martimpassos
Copy link

@mathewjordan and @adamjarling might want to take a look at how I described and where I placed Clover.

Copy link
Member

@mathewjordan mathewjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martimpassos, see my note about the removal under IIIF Viewers. I still think it be included there in some way.

readme.md Show resolved Hide resolved
readme.md Show resolved Hide resolved
readme.md Show resolved Hide resolved
@martimpassos
Copy link
Author

So should Clover appear twice in the list (as viewer and as presentation tool) or should I say in the viewer entry that it also encompasses other front-end utilities?

@mathewjordan
Copy link
Member

Hi @martimpassos. Thank you for putting this in.

I understand that multiple lines might be out of sorts for this type of thing, however, the Viewer is just one component for Clover IIIF and I think does belong as its own line item as it is also incorporated into the IIIF Cookbook viewer matrix.

In the IIIF Viewers section, it could be, with the Viewer specific description and link to the Viewer component:

[Clover IIIF Viewer](https://samvera-labs.github.io/clover-iiif/docs/viewer) - Presentation API Manifest and Collection viewer handling Image, Sound, and Video canvases for React.js

Clover IIIF itself is a Presentation API component library or suite and I do think also belongs in the Presentation API Libraries section with the description you noted:

[Clover IIIF](https://samvera-labs.github.io/clover-iiif/) - IIIF front-end React toolkit including a multimedia viewer, image slider, and HTML5 primitives for manifest properties.

Copy link
Member

@mathewjordan mathewjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martimpassos 👍

@mathewjordan
Copy link
Member

@regisrob Might be able to give a final review of things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants