Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recipe #0009 — Simplest Manifest - Multiple Related Images (book, etc.) #153

Merged
merged 32 commits into from
Oct 16, 2020
Merged

Recipe #0009 — Simplest Manifest - Multiple Related Images (book, etc.) #153

merged 32 commits into from
Oct 16, 2020

Conversation

glenrobson
Copy link
Member

Importing @regisrob recipe from #150

@regisrob
Recipe #9 — Simplest Manifest - Multiple Related Images (book, etc.)
525b2e5
@regisrob
Improve text
9e80bd0 
- focus example on a book
- add an implementation note mentioning thumbnails usage
@regisrob
Add link to prezi3-thumbnail
b2df417
@regisrob
Update manifest: add real canvas labels
1e25839
@regisrob
Rework recipe's texts
5cd4697 
- change texts, title and summary
- move paragraphs to impl notes
@regisrob
Update manifest.json
6225afb 
- new label
- behavior paged
- 4 canvases
- canvas thumbnails
- real urls and sizes based on image fixtures
@regisrob
Add link to UV
7c4eb71
@regisrob
Fix manifest.json, using the correct body property
6f98e83
@regisrob
Fix link to UV
84a9af8
@glenrobson glenrobson mentioned this pull request Apr 20, 2020
Closed
5 tasks
@glenrobson
Copy link
Member Author

Recipe available at: https://preview.iiif.io/cookbook/0009-book-1/recipe/0009-book-1/

@glenrobson
Copy link
Member Author

1 small change. Would it be possible to add the width and the height for the canvas thumbnails? In the spec in the thumbnail section it says:

"Images and videos should have the width and height properties, and time-based media should have the duration property"

and I think for clients to make use of the thumbnail they would probably need the dimensions.

@regisrob
Copy link
Member

@glenrobson Yes, I will add them ;)

@regisrob
Add w/h on canvas thumbnails
99f3ce7
@regisrob
Merge pull request #155 from regisrob/0009-book-1
69948f4 
Small changes to recipe 0009-book-1 after first recipe review
@glenrobson
Copy link
Member Author

(Automated comment): Branch available for testing at https://preview.iiif.io/cookbook/0009-book-1

@glenrobson glenrobson added the meta: ready-for-editors Ready for Cookbook editor review label Apr 28, 2020
@regisrob
Add jekyll includes for viewer links and jsonviewer
6ca548d 
... after having merged master into 0009-book-1 branch
@glenrobson
Copy link
Member Author

Hi Régis,

The cookbook editors reviewed your recipe and wondered if you could make the following changes:

  • Move 2nd paragraph from Use case to Implementation note (the one starting with "The sample Manifest below represents")
  • Can you use a IIIF image service in canvses rather than flat images?
  • Can you add the following related recipes to thumbnail recipe (thumbnail algorithm / discussion) and to Simple Image Service (Image Service for single image (24,25))
  • Add in the viewer include into the recipe and we note the UV is currently not working but by moving to an image service that might avoid the current known issue with flat images on fixtures not setting the correct CORS information.
  • At the end of the recipe there are three ``` symbols

Thanks

@glenrobson glenrobson removed the meta: ready-for-editors Ready for Cookbook editor review label May 5, 2020
@regisrob
Copy link
Member

regisrob commented May 5, 2020

Hi Glen, thanks for the feedback, I will make the proposed changes. I was already thinking of adding the image services (partly because M3 seems to require it on the thumbnail). I may have fixed the ``` symbols already but I will double check.

@regisrob
Copy link
Member

regisrob commented May 9, 2020

Hi @glenrobson, this point is unclear to me: "Can you add the following related recipes to thumbnail recipe (thumbnail algorithm / discussion) and to Simple Image Service (Image Service for single image (24,25))".
Should I just point to these two recipes from the “Related recipes” section of 0009-book-1?
Thanks

@glenrobson
Copy link
Member Author

Yes, that was the intention. So just add the thumbnail recipe (thumbnail algorithm / discussion) and to Simple Image Service (Image Service for single image (24,25)) below the Related recipes heading.

@regisrob
Update recipe 9 based on feedback from editors (#161)
9bca4d6 
* move 2nd paragraph from Use case to Implementation note
* add an image service to each canvas
* add 2 related recipes
@glenrobson glenrobson mentioned this pull request Jul 1, 2020
Open
@github-actions github-actions bot temporarily deployed to production July 2, 2020 01:46 Inactive
@github-actions github-actions bot temporarily deployed to production July 2, 2020 01:50 Inactive
@github-actions github-actions bot temporarily deployed to stagging July 2, 2020 01:55 Inactive
@github-actions github-actions bot temporarily deployed to staging July 2, 2020 12:34 Inactive
@glenrobson glenrobson added meta: approved-by-trc Recipe has been approved by the TRC and removed meta: ready-for-trc Issue is ready for TRC review labels Jul 29, 2020
@glenrobson glenrobson added this to TRC Approved - waiting for merge in Recipe Progress Aug 7, 2020
@github-actions github-actions bot temporarily deployed to staging August 7, 2020 18:26 Inactive
@regisrob
Review title and text per TRC feedback
733b17a 
- change recipe title
- adjust first paragraph explaining the use case
- replace "IIIF Presentation resource" by "Manifest"
- get rid of useless "etc."
- fix english spelling per @triplingual's comment
- update titles of linked recipes
@regisrob
Copy link
Member

Last commit addresses the remarks from the TRC call, so ready for new review.

glenrobson
glenrobson commented Oct 5, 2020
View reviewed changes
_includes/links.md Outdated Show resolved Hide resolved
index.md Outdated Show resolved Hide resolved
@glenrobson glenrobson added the meta: ready-to-merge Pull request is ready to merge into main branch label Oct 9, 2020
@glenrobson
Copy link
Member Author

Changes requested by TRC made and approved by cookbook group.

@glenrobson glenrobson merged commit def9e25 into master Oct 16, 2020
Recipe Progress automation moved this from TRC Approved - waiting for merge to Done Oct 16, 2020
@glenrobson glenrobson deleted the 0009-book-1 branch October 16, 2020 13:44
@triplingual triplingual removed the meta: ready-to-merge Pull request is ready to merge into main branch label Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regisrob regisrob regisrob left review comments

Assignees

@regisrob regisrob

Labels
meta: approved-by-trc Recipe has been approved by the TRC
Projects
Recipe Progress
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Book (simplest, > 1 canvas)
3 participants
@glenrobson @regisrob @triplingual