-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0219 using caption file #223
Conversation
Just for completeness here are the comments from the Cookbook editors:
Overall decision was this was ready for TRC with the above comments incorporated. |
Hi Maria, I've checked the changes requested and this looks good to go apart from the following change:
I've also merged in a recipe that was approved from the last TRC so if you could update from Master that would be great. Thanks Glen |
For future reference |
Recipe approved by TRC with only Simeon's comment to address: Note there is ongoing discussion in the IIIF #AV slack on a few extra issues but these were outside of the timeline for the TRC review. I suggest we merge this recipe and create an issue for the points in the #av discussion and then handle the changes like we have with previous recipes. If its minor we can make the change and inform TRC, if its more involved take it for another round of approval. I suspect its the second option with the discussion but we'll see how it resolves. |
Thanks Maria, those changes look great. I'm going to merge this now. |
First Draft.