Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0219 using caption file #223

Merged
merged 20 commits into from
Mar 10, 2021
Merged

0219 using caption file #223

merged 20 commits into from
Mar 10, 2021

Conversation

mcwhitaker
Copy link
Contributor

First Draft.

@glenrobson glenrobson added this to Cookbook Editor Review in Recipe Progress Jan 8, 2021
@glenrobson glenrobson added the meta: approved-by-trc Recipe has been approved by the TRC label Jan 9, 2021
@glenrobson glenrobson moved this from Cookbook Editor Review to TRC Review in Recipe Progress Jan 9, 2021
@glenrobson
Copy link
Member

Just for completeness here are the comments from the Cookbook editors:

  • Add a label for the VTT file in manifest
  • Mirador issue is now fixed in dev version: https://deploy-preview-3379--mirador-dev.netlify.app/__tests__/integration/mirador/video.html so its OK to include Mirador in the link.
  • Remove UV as this currently isn't working.
  • May need to remove the numbers that annotate the subtitles in the VTT file although the file does validate.
  • Related recipes
    • Add: seeAlso and rendering
    • Add: Transcript - this would be an alternative rendering
  • In implementation note can you explain that a transcription which is a text based version of the resource would be a rendering and captions are x and live in y.
  • Potentially rename title to: “Caption and subtitles with your video content”.
  • Restrictions:
    • Add note the effect of: "VTT was chosen due to its wide support in browsers. Other formats are supported in IIIF but may not display in viewers. "

Overall decision was this was ready for TRC with the above comments incorporated.

@glenrobson glenrobson linked an issue Jan 9, 2021 that may be closed by this pull request
@glenrobson glenrobson added meta: ready-for-trc Issue is ready for TRC review and removed meta: approved-by-trc Recipe has been approved by the TRC labels Jan 9, 2021
@glenrobson
Copy link
Member

Hi Maria,

I've checked the changes requested and this looks good to go apart from the following change:

  • Add: seeAlso and rendering to related recipes.

I've also merged in a recipe that was approved from the last TRC so if you could update from Master that would be great.

Thanks

Glen

@glenrobson
Copy link
Member

For future reference rendering is listed as a related recipe and Maria and I discussed seeAlso and as its not in the recipe it doesn't seem to make sense to add it as a related recipe.

@glenrobson
Copy link
Member

Recipe approved by TRC with only Simeon's comment to address:

IIIF/trc#59 (comment)

Note there is ongoing discussion in the IIIF #AV slack on a few extra issues but these were outside of the timeline for the TRC review. I suggest we merge this recipe and create an issue for the points in the #av discussion and then handle the changes like we have with previous recipes. If its minor we can make the change and inform TRC, if its more involved take it for another round of approval. I suspect its the second option with the discussion but we'll see how it resolves.

@glenrobson glenrobson moved this from TRC Review to TRC Approved - waiting for merge in Recipe Progress Feb 11, 2021
@triplingual triplingual added meta: approved-by-trc Recipe has been approved by the TRC and removed meta: ready-for-trc Issue is ready for TRC review labels Mar 9, 2021
@glenrobson
Copy link
Member

Thanks Maria, those changes look great. I'm going to merge this now.

@glenrobson glenrobson merged commit 739d987 into master Mar 10, 2021
Recipe Progress automation moved this from TRC Approved - waiting for merge to Done Mar 10, 2021
@glenrobson glenrobson deleted the 0219-using-caption-file branch March 10, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: approved-by-trc Recipe has been approved by the TRC
Projects
Development

Successfully merging this pull request may close these issues.

Using a caption file with A/V content
3 participants