Make validator work with python2 and python3 #40
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have done a number of things including: use of relative imports, replace use of
dict.has_key(key)
withkey in dict
, change imports for things likeurllib2
andBytesIO
to work with both py2 and py3, additionaldecode('utf-8')
to deal with bytes returns in py3, and significantly reduce the black magic for importing test modules (which didn't work in py3, now inTestSuite.__init__
.I have tested this as part of running the validator under py2 and py3 as I work on migrating https://github.com/zimeon/iiif/tree/image_api_2.1 to work with Image API 2.1 on both py2 and py3.
I bumped the version number to 1.0.1 and will update pypi when we agree things are good.