Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make validator work with python2 and python3 #40

Merged
merged 2 commits into from
May 20, 2016
Merged

Make validator work with python2 and python3 #40

merged 2 commits into from
May 20, 2016

Conversation

zimeon
Copy link
Member

@zimeon zimeon commented May 18, 2016

Have done a number of things including: use of relative imports, replace use of dict.has_key(key) with key in dict, change imports for things like urllib2 and BytesIO to work with both py2 and py3, additional decode('utf-8') to deal with bytes returns in py3, and significantly reduce the black magic for importing test modules (which didn't work in py3, now in TestSuite.__init__.

I have tested this as part of running the validator under py2 and py3 as I work on migrating https://github.com/zimeon/iiif/tree/image_api_2.1 to work with Image API 2.1 on both py2 and py3.

I bumped the version number to 1.0.1 and will update pypi when we agree things are good.

@azaroth42
Copy link
Member

Verified locally with 2.7 👍

@azaroth42 azaroth42 merged commit 563a64e into IIIF:master May 20, 2016
@zimeon
Copy link
Member Author

zimeon commented May 20, 2016

Have packaged and updated on pypi. My IIIF library code now uses the pypi packages to run tests in py2/py3 on travis. All seems good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants