Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message cleanup #64

Merged
merged 4 commits into from Sep 26, 2018
Merged

Error message cleanup #64

merged 4 commits into from Sep 26, 2018

Conversation

glenrobson
Copy link
Member

Fixes: #63

Currently AWS sends a email of there are a high percentage of non 200 requests. This means I get notified regularly when bots try and crawl the sites for files that don't exist. The image validator currently returns 500 if it receives a POST for a page that doesn't exist. This pull request does the following:

  • Return 404 for a page that doesn't exist
  • Hide common requests from the apache log for files that don't exist (404 is still returned). This should stop the notifications for known files that don't exist (see Error message cleanup #64 for a list).
  • Redirects http://image-validator.iiif.io/ to https://iiif.io/api/image/validator/ as there is no page at the route of this webapp.

This should mean notifications are only sent if there is a genuine problem with the service.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 33.424% when pulling 2662e3c on error_message_cleanup into 97625e1 on master.

Copy link
Member

@zimeon zimeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible

@zimeon zimeon merged commit 857f569 into master Sep 26, 2018
@zimeon zimeon deleted the error_message_cleanup branch September 26, 2018 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants