Feature/integration improvements #1043
Conversation
radpet
force-pushed
the
feature/integration-improvements
branch
from
274bb7f
to
c0313d6
Compare
| }; | ||
|
|
||
| if (_this.activeEditor.isDirty()) { | ||
| new $.DialogBuilder().confirm(i18n.t('cancelAnnotation'),function(result){ |
There was a problem hiding this comment.
Looks like you are not passing the isDirty check in the event publisher so it's showing the dialog on an empty text editor.
|
@radpet I noticed (and I don't know if this happened in this PR or a previous one), but when you go into Edit mode for an annotation and click on one of the shapes and then click outside of it, it draws that shape. It should only draw a shape when the user explicitly selects one of the shapes by the top icons. A user should be able to click around the rest of the image when in pointer mode without drawing a shape. I believe this was working at one point, so I don't know when it broke. |
Nah this happens in annotation-work too... I'll try to fix it in another pull request. |
radpet
force-pushed
the
feature/integration-improvements
branch
from
c0313d6
to
a059793
Compare
radpet
force-pushed
the
feature/integration-improvements
branch
from
a059793
to
1b18335
Compare
radpet
force-pushed
the
feature/integration-improvements
branch
from
1b18335
to
57ea361
Compare
radpet
force-pushed
the
feature/integration-improvements
branch
from
57ea361
to
676306e
Compare
…vent name and handler on subscribe in order unsubscripe only for the registered handler Refactor draw-tool to unsubscribe from events when osd is destroyed Refactor overlay to not remove all osd handlers when destroyed Refactor annotationTooltip to not include any save/create/edit annotation logic AvailableExternalComments setting now shows tooltip Go to pointer mode when refresh is clicked
radpet
force-pushed
the
feature/integration-improvements
branch
from
676306e
to
bb4edbc
Compare
|
We need that bug fixed as soon as possible as we will be doing a code freeze early next week. |
|
Right I will start fixing it right now, meanwhile please check this pull request. |
This pull request fixes:
Memory leaks caused by not unsubscribing from events when object is not used any more
Handle refresh annotation action properly
This pull request adds:
Events that handle all annotation logic inside overlay in order to remove them from the annotation-tooltip object
Option whether to proceed to confirmation screen after save beeing clicked when you edit annotation and have no shapes.