Thumbnail #931
Merged
Thumbnail #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Option for .preview-thumb
Create preview-thumb as a 'div-class'
Changed previev -> preview
|
Is there any problems with my PR? Shall I correct something? |
|
I haven't had a chance to look at it yet, but plan to today. |
|
@fe-kre It looks fine. In general, I'm not sure what the best behavior is when the user resizes the window down. The default behavior is to have the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am sorry again for my approach, I am really new to Github and learn their procedures.
I correct my mistake at #922.
Hopefully, now everything works as expected.