Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fake local JSONBlob endpoint. #942

Merged

Conversation

dicksonlaw583
Copy link
Contributor

This is designed to replace the default JSONBlob endpoint for bookmarking in demo setups, removing the dependency on jsonblob.com.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 40.296% when pulling 54d1f35 on dicksonlaw583:local_fake_jsonblob into 6cf7f91 on IIIF:release2.1.

@aeschylus
Copy link
Collaborator

This seems like a good addition that I'm happy to merge. Could you write a few tests for this (coverage is decreasing)?

Long-term I think we need to figure out how to remove jsonblob entirely from the codebase and just let people get the internal state from the API, perhaps following that up with a guide on how to persist said state in various ways.

Thanks @dicksonlaw583.

@dicksonlaw583
Copy link
Contributor Author

Tests added for the local JSON Blob API.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.2%) to 41.556% when pulling e4f0386 on dicksonlaw583:local_fake_jsonblob into 6cf7f91 on IIIF:release2.1.

@aeschylus
Copy link
Collaborator

@aeschylus
Copy link
Collaborator

I made some minor edits to the wiki page, but otherwise this looks good for now.

We will probably remove the feature entirely in the upcoming release, to facilitate different methods of persisting the state, but for now this will help development, and provide a way forward if that falls out of the release.

@aeschylus aeschylus merged commit b1d31b3 into ProjectMirador:release2.1 Jun 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants