Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest order #943

Merged
merged 3 commits into from Jun 1, 2016
Merged

manifest order #943

merged 3 commits into from Jun 1, 2016

Conversation

rsinghal
Copy link
Collaborator

@rsinghal rsinghal commented Jun 1, 2016

closes #570

Added preserveManifestOrder setting to determine whether or not to display the manifests in a particular order. By default, Mirador does the original behavior - displaying items in the manifest page as they resolve, because preserveManifestOrder is set to false. If set to true the code attempts to determine the index value for that manifest and insert it properly according to the other manifests that have already been added to that page. If the index value for a manifest is not available for some reason (i.e. added by URL or the URI in the data array does not match the URI in the manifest itself), default to adding them to the top, as Mirador typically adds them.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 40.652% when pulling 19e4d43 on 200-manifest-order into 6cf7f91 on release2.1.

@rsinghal rsinghal changed the title 200 manifest order manifest order Jun 1, 2016
@aeschylus
Copy link
Collaborator

Neat.

@aeschylus aeschylus merged commit 76a35e7 into release2.1 Jun 1, 2016
@aeschylus
Copy link
Collaborator

👍 for tests!

@rsinghal rsinghal deleted the 200-manifest-order branch June 2, 2016 15:06
@jpadfield
Copy link

Hi, I have just been exploring the "preserveManifestOrder" option and it does not seem to be working in the current version. I just wanted to check if it was supposed to be working yet?
Thanks

@rsinghal
Copy link
Collaborator Author

Hmm, I will take a look @jpadfield

@rsinghal
Copy link
Collaborator Author

You are right, something is not working correctly. I reopened #570. If you have any more info, please add it to that ticket.

@jpadfield
Copy link

OK, Thanks, I do not have any specific new information but I will add
anything new when it comes up. If you need me to test anything please
let me know.

Joe

On 18/10/16 09:36, Rashmi Singhal wrote:

You are right, something is not working correctly. I reopened #570
#570. If you have
any more info, please add it to that ticket.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#943 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQ7Htfx9jYmp7hGRWMoWrSqDjaT7iu2cks5q1IUogaJpZM4Iru6j.

Joseph Padfield
Conservation Scientist
Scientific Department
The National Gallery
Trafalgar Square
London WC2N 5DN
+44 (0)20 7747 2553
http://research.ng-london.org.uk
http://www.twitter.com/JoePadfield

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants