Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified slot.js to allow for collection drag and drop #956

Conversation

jeffreycwitt
Copy link
Contributor

modified slot.js to allow for collection drag and drop that then moves user to manifest list view.

Should resolve issue: #941

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 41.235% when pulling 8f1dc2e on jeffreycwitt:feature/collection-drag-and-drop into e8a5739 on IIIF:release2.1.

//TODO:
//this works;
//but you might want to check if some "publish" action would be better
_this.addItem();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, but I think this will be okay for now. We need to think about how the different top-level screens can be represented in the data structure, and how to update them accordingly without calling the methods of things.

Any update needs to ultimately be done through an "action", so that the state manager can send out notifications to subscribers(UI components) that depend on that state.

@aeschylus
Copy link
Collaborator

This seems like a good way forward using existing patterns. Although the coverage has decreased, I'm adding going ahead with it since the slot.js d-n-d code needs some serious refactoring to be testable. The different branches seriously need to be broken out into functions.

@aeschylus aeschylus merged commit de41163 into ProjectMirador:release2.1 Jun 15, 2016
@jeffreycwitt
Copy link
Contributor Author

Hooray!!!

On Wed, Jun 15, 2016 at 3:19 PM, aeschylus notifications@github.com wrote:

Merged #956 #956.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#956 (comment), or mute the
thread
https://github.com/notifications/unsubscribe/ABF_PVg8AjgCJ0cC_dJEKogS0zyE5Fy0ks5qMFAxgaJpZM4I0t0K
.

Dr. Jeffrey C. Witt
Philosophy Department
Loyola University Maryland
4501 N. Charles St.
Baltimore, MD 21210
www.jeffreycwitt.com

@jeffreycwitt jeffreycwitt deleted the feature/collection-drag-and-drop branch June 15, 2016 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants