Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issue that causes the 500 error #98

Merged
merged 2 commits into from Mar 27, 2020
Merged

Fixing issue that causes the 500 error #98

merged 2 commits into from Mar 27, 2020

Conversation

glenrobson
Copy link
Member

@glenrobson glenrobson commented Mar 27, 2020 •
edited

A number of issues here. The error finder seemed to struggle when the error was in the root.

Also decided to limit the allowable fields in the manifest to catch old fields like sequence

Fixes #97

@glenrobson
Fixing issue 97 500 error
1651ddf 
A number of issues here. The error finder seemed to struggle when the error was in the root.

Also decided to limit the allowable fields in the manifest to catch old fields like sequence
@glenrobson glenrobson changed the title Fixing issue https://github.com/IIIF/presentation-validator/issues/97 500 error Fixing issue that causes the 500 error Mar 27, 2020
@coveralls
Copy link

coveralls commented Mar 27, 2020 •
edited

Coverage Status

Coverage remained the same at 83.459% when pulling 52b2c02 on fix_manifest_error into cc92e81 on master.

@glenrobson glenrobson merged commit 4e98e04 into master Mar 27, 2020
@glenrobson glenrobson deleted the fix_manifest_error branch March 27, 2020 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manifest causing 500 error when testing 3.0
2 participants
@glenrobson @coveralls