Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe 10: Book (viewingDirection variations) #40

Open
glenrobson opened this issue Jul 1, 2020 · 10 comments
Open

Recipe 10: Book (viewingDirection variations) #40

glenrobson opened this issue Jul 1, 2020 · 10 comments
Assignees
Labels
Milestone

Comments

@glenrobson
Copy link
Member

Links

Background and Summary

This recipe introduces viewingDirection and gives examples of right-to-left and top-to-bottom. The example content has been donated by the UCLA and fits with the example. This recipe also links to viewers that show this viewing hint in action.

A +1 is the recipe is OK to go through to the master
A -1 is that is not OK and a comment in this issue should say what needs to be done

@glenrobson glenrobson added this to the July 2020 milestone Jul 1, 2020
@ahankinson
Copy link

I think there is a link that is messed up in the implementation notes section:

“ see also the [Book (paging variations)][0011] recipe)”

@scossu
Copy link

scossu commented Jul 9, 2020

Also, the last section includes the (supposedly boilerplate) text "Provide a bulleted list..."

@scossu
Copy link

scossu commented Jul 9, 2020

The links in the last section don't parse correctly as well.

@scossu
Copy link

scossu commented Jul 9, 2020

According to #41 (comment) the non-parsing links are not an issue. The boilerplate text issue is still open though.

@triplingual
Copy link

Noting for posterity that I voted 👍🏻 on this recipe that I authored and sponsored.

@zimeon
Copy link
Member

zimeon commented Jul 14, 2020

I think this needs a but more tidying for the reasons noted above. I also wonder whether the title "Navigation Direction" is going to cause confusion -- the text mentions navigation only once and the property is viewingDirection. I think it would be better to say something like "Viewing direction and its effect on navigation"

@azaroth42
Copy link
Member

azaroth42 commented Jul 14, 2020

As above, but also the first sentence in the Use Case section should introduce the use case (for this recipe, being rtl reading) with an example that makes sense to the use. The use case isn't "Sample manifests" ... that's what all recipes are :)

I think this should be tidied ... but I don't think we need to return it to the TRC for another round of vetting as the issues are minor editing, rather than substantial. So please consider my 👎 as a 👍 once the fixes are done.

@glenrobson
Copy link
Member Author

Issue 40 (Recipe 10: Book (viewingDirection variations))

+1: 14 [ahankinson cubap emulatingkat gigamorph hadro irv jonhartzler joshuago78 julsraemy jwd mejackreed regisrob rentonsa tpendragon]
0: 0 []
-1: 5 [azaroth42 mikeapp mixterj scossu zimeon]

Result: 14 / 19 = 0.74

Super majority is in favor, issue is approved

@triplingual
Copy link

triplingual commented Jul 24, 2020

Thanks for all the constructive feedback. As I'm reading it, the to-do list is

  • Remove boilerplate text: "Provide a bulleted list..."
  • Change title to something like "Viewing direction and its effect on navigation"
  • First sentence in the Use Case section should introduce the use case (for this recipe, being rtl reading) with a sensible example

This is by pulling from the comments.

@glenrobson
Copy link
Member Author

Issue 40 (Recipe 10: Book (viewingDirection variations))

+1: 18 [ahankinson brndgtl cjnishioka cubap emulatingkat gigamorph hadro irv jonhartzler joshuago78 julsraemy jwd mejackreed mposton-folger nfreire regisrob rentonsa tpendragon]
0: 0 []
-1: 5 [azaroth42 mikeapp mixterj scossu zimeon]
Not TRC: 0 []
Ineligible: 0 []

Result: 18 / 23 = 0.78

Super majority is in favor, issue is approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants