-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recipe 10: Book (viewingDirection variations) #40
Comments
I think there is a link that is messed up in the implementation notes section: “ see also the [Book (paging variations)][0011] recipe)” |
Also, the last section includes the (supposedly boilerplate) text "Provide a bulleted list..." |
The links in the last section don't parse correctly as well. |
According to #41 (comment) the non-parsing links are not an issue. The boilerplate text issue is still open though. |
Noting for posterity that I voted 👍🏻 on this recipe that I authored and sponsored. |
I think this needs a but more tidying for the reasons noted above. I also wonder whether the title "Navigation Direction" is going to cause confusion -- the text mentions navigation only once and the property is |
As above, but also the first sentence in the Use Case section should introduce the use case (for this recipe, being rtl reading) with an example that makes sense to the use. The use case isn't "Sample manifests" ... that's what all recipes are :) I think this should be tidied ... but I don't think we need to return it to the TRC for another round of vetting as the issues are minor editing, rather than substantial. So please consider my 👎 as a 👍 once the fixes are done. |
Issue 40 (Recipe 10: Book (viewingDirection variations))+1: 14 [ahankinson cubap emulatingkat gigamorph hadro irv jonhartzler joshuago78 julsraemy jwd mejackreed regisrob rentonsa tpendragon] Result: 14 / 19 = 0.74Super majority is in favor, issue is approved |
Thanks for all the constructive feedback. As I'm reading it, the to-do list is
This is by pulling from the comments. |
Issue 40 (Recipe 10: Book (viewingDirection variations))+1: 18 [ahankinson brndgtl cjnishioka cubap emulatingkat gigamorph hadro irv jonhartzler joshuago78 julsraemy jwd mejackreed mposton-folger nfreire regisrob rentonsa tpendragon] Result: 18 / 23 = 0.78Super majority is in favor, issue is approved |
Links
Background and Summary
This recipe introduces
viewingDirection
and gives examples ofright-to-left
andtop-to-bottom
. The example content has been donated by the UCLA and fits with the example. This recipe also links to viewers that show this viewing hint in action.A +1 is the recipe is OK to go through to the master
A -1 is that is not OK and a comment in this issue should say what needs to be done
The text was updated successfully, but these errors were encountered: