Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage permission request for mobile apk #4

Closed
johnd0e opened this issue Nov 24, 2018 · 5 comments
Closed

Storage permission request for mobile apk #4

johnd0e opened this issue Nov 24, 2018 · 5 comments
Labels
bug Something isn't working mobile

Comments

@johnd0e
Copy link
Contributor

johnd0e commented Nov 24, 2018

On start I've got only 1 permisson request: Location.
And there were no request about Storage access which is necessary e.g. for external plugins.

I was able to set the permission manually but it will be better if it requested on apk start.

@johnd0e
Copy link
Contributor Author

johnd0e commented Dec 2, 2018

@modos189
Copy link
Contributor

modos189 commented Dec 2, 2018

done

@johnd0e
Copy link
Contributor Author

johnd0e commented Dec 3, 2018

There are still some issues with it.
I successfully set the permission and can access user scripts, but on every launch I still see the toast Permissions are required if you want to use user scripts or cache on SDCard.

@modos189 modos189 reopened this Dec 5, 2018
@modos189 modos189 added the bug Something isn't working label Dec 11, 2018
@modos189
Copy link
Contributor

Request write storage permissions only if you add scripts. Saving the tile cache does not require additional permissions. cdb7e89

@johnd0e
Copy link
Contributor Author

johnd0e commented Dec 12, 2018

Request write storage permissions only if you add scripts.

When I open *.user.js at Chrome webpage (or in file manager) it proposes list of applications.
I select IITC and after confirmation all seems ok, but then Plugins settings screen appears without user plugins.

There should be permission request, I suppose.

And I think this even will not be enough, consider this case:
IITC was once installed and we have user plugins in IITC-Mobile/plugins directory.
Then we uninstall apk, and install it again.
Will we get permission request?

@johnd0e johnd0e added the mobile label Jan 23, 2019
tumik pushed a commit to tumik/iitc that referenced this issue Jan 28, 2019
data not defined on passcode failure means exception and no feedback
le-jeu pushed a commit to le-jeu/ingress-intel-total-conversion that referenced this issue Feb 7, 2021
parse history in visited/captured/scanned fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mobile
Projects
None yet
Development

No branches or pull requests

2 participants