Request exit #23
Merged
Request exit #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o take input from the stdin from subprocess.PIPE of client tested for both posetrl and rl4real flow working finegit add gRPCModelRunner.h
Minor change converting the added_port to string
Changed the implementation of requestExit from the Signals to the stdin i.e the server will wait for the input from the stdin using the subprocess.PIPE from the client Tested for both rl4real and posetrl flow
svkeerthy
previously approved these changes
Mar 1, 2024
svkeerthy
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the logic of requestExit(code for shutdown of server) to other implementation which uses the subprocess.PIPE tested for both rl4real and posetrl flows