Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FindOnnx cmake, Removed JSON.cpp & JSON.h copies #25

Merged
merged 7 commits into from May 14, 2024
Merged

Conversation

Umesh-k26
Copy link
Collaborator

  • Updated onnx linking with find_package command
  • To remove the copies of JSON implementations.
    Currently TensorSpec.cpp takes JSON.h from llvm/include if we build it inside LLVM, and from /usr/include if we build it standalone.
    Both the files have different implementations for json::Path class, hence TensorSpec.cpp won't compile.
    To fix it, compile time flag has been linked with SerDesLib and json::Path has been defined accordingly.

@Umesh-k26 Umesh-k26 requested a review from svkeerthy May 5, 2024 10:03
Copy link
Member

@svkeerthy svkeerthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the README to reflect the upgraded gRPC and protobuf versions.

include/MLModelRunner/gRPCModelRunner.h Show resolved Hide resolved
include/SerDes/baseSerDes.h Show resolved Hide resolved
test/MLBridgeTest.cpp Outdated Show resolved Hide resolved
test/MLBridgeTest.cpp Outdated Show resolved Hide resolved
test/MLBridgeTest.cpp Show resolved Hide resolved
test/MLBridgeTest.cpp Show resolved Hide resolved
test/MLBridgeTest.cpp Show resolved Hide resolved
@Umesh-k26 Umesh-k26 requested a review from svkeerthy May 14, 2024 04:13
@svkeerthy svkeerthy merged commit 53bf989 into main May 14, 2024
3 checks passed
@svkeerthy svkeerthy deleted the onnx-config branch May 14, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants