Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle ID is literally `$(PRODUCT_BUNDLE_IDENTIFIER)` #448

Closed
vitorgalvao opened this issue Feb 15, 2019 · 3 comments

Comments

@vitorgalvao
Copy link

commented Feb 15, 2019

Discovered due to a submission to Homebrew Cask.

On qtpass.plist, CFBundleIdentifier is literally $(PRODUCT_BUNDLE_IDENTIFIER).

It seems the script that generates that value (likely the Makefile which is in .gitignore), quoted it literally instead of executing.

@vitorgalvao vitorgalvao referenced this issue Feb 15, 2019
4 of 10 tasks complete

@annejan annejan added the macOS label Aug 20, 2019

@annejan annejan closed this in 034fe37 Aug 20, 2019

@annejan

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

Related #457

It should indeed be replaced but apparently is not . . now hardcoded to QtPass

@vitorgalvao

This comment has been minimized.

Copy link
Author

commented Aug 20, 2019

now hardcoded to QtPass

That’s an atypical bundle identifier. It should instead be org.qtpass.

@annejan

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

My lack of macOS lore is showing . .

Will change in next release (due later this week) . .

@annejan annejan reopened this Aug 20, 2019

@annejan annejan closed this in 9a15ef3 Aug 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.