Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle ID is literally $(PRODUCT_BUNDLE_IDENTIFIER) #448

Closed
vitorgalvao opened this issue Feb 15, 2019 · 3 comments
Closed

Bundle ID is literally $(PRODUCT_BUNDLE_IDENTIFIER) #448

vitorgalvao opened this issue Feb 15, 2019 · 3 comments
Labels
macOS

Comments

@vitorgalvao
Copy link

vitorgalvao commented Feb 15, 2019 •
edited
Loading

Discovered due to a submission to Homebrew Cask.

On qtpass.plist, CFBundleIdentifier is literally $(PRODUCT_BUNDLE_IDENTIFIER).

It seems the script that generates that value (likely the Makefile which is in .gitignore), quoted it literally instead of executing.
@vitorgalvao vitorgalvao mentioned this issue Feb 15, 2019
Closed
10 tasks
@annejan annejan added the macOS label Aug 20, 2019
@annejan
Copy link
Member

annejan commented Aug 20, 2019

Related #457

It should indeed be replaced but apparently is not . . now hardcoded to QtPass

@vitorgalvao
Copy link
Author

now hardcoded to QtPass

That’s an atypical bundle identifier. It should instead be org.qtpass.

@annejan
Copy link
Member

annejan commented Aug 20, 2019

My lack of macOS lore is showing . .

Will change in next release (due later this week) . .

@annejan annejan reopened this Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
macOS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@annejan @vitorgalvao