New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nested template argument list compile error #346

Merged
merged 1 commit into from Jan 10, 2018

Conversation

Projects
None yet
5 participants
@martinburchell
Contributor

martinburchell commented Jan 9, 2018

Fixes this compilation error:

In file included from ../../../src/imitatepass.h:5:0,
from ../../../src/qtpasssettings.h:5,
from ../../../src/storemodel.h:10,
from ../../../src/util.h:4,
from tst_util.cpp:1:
../../../src/simpletransaction.h:11:54: error: ‘>>’ should be ‘> >’ within a nested template argument list
std::queue<std::pair<Enums::PROCESS, Enums::PROCESS>> transactionQueue;

@coveralls

This comment has been minimized.

coveralls commented Jan 9, 2018

Coverage Status

Coverage remained the same at 1.776% when pulling 170cd00 on aptivate:fix-nested-template-argument-list-compile-error into 99601cf on IJHack:master.

@tezeb

This comment has been minimized.

Contributor

tezeb commented Jan 9, 2018

@martinburchell

This comment has been minimized.

Contributor

martinburchell commented Jan 9, 2018

@tezeb g++ (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4

@annejan annejan merged commit ad455b4 into IJHack:master Jan 10, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
linthub Linthub has cleared the pull request, no code style suggestions found.
Details
@5bentz

This comment has been minimized.

5bentz commented Feb 10, 2018

The last commit 2c7fcca reverted this fix ! Causing compilation errors on Ubuntu 16.04 LTS.

5bentz referenced this pull request Feb 10, 2018

annejan added a commit that referenced this pull request Feb 10, 2018

@annejan

This comment has been minimized.

Member

annejan commented Feb 10, 2018

This has been re-applied d3787d2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment