Fix nested template argument list compile error #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not necessary since C++11, which afair is how QtPass shall be
compiled.
Which compiler(version) are you using?
|
|
@tezeb g++ (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4 |
|
The last commit 2c7fcca reverted this fix ! Causing compilation errors on Ubuntu 16.04 LTS. |
|
This has been re-applied d3787d2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this compilation error:
In file included from ../../../src/imitatepass.h:5:0,
from ../../../src/qtpasssettings.h:5,
from ../../../src/storemodel.h:10,
from ../../../src/util.h:4,
from tst_util.cpp:1:
../../../src/simpletransaction.h:11:54: error: ‘>>’ should be ‘> >’ within a nested template argument list
std::queue<std::pair<Enums::PROCESS, Enums::PROCESS>> transactionQueue;