Fix & make clearClipboard more robust #359
The current version had 2 bugs:
I fixed these bugs and clear both clipboard types if they contain the
@@ Coverage Diff @@ ## master #359 +/- ## ========================================= + Coverage 2.92% 2.92% +<.01% ========================================= Files 36 36 Lines 2699 2698 -1 Branches 360 361 +1 ========================================= Hits 79 79 + Misses 2619 2618 -1 Partials 1 1
The current version had 2 bugs: 1) The clippedText was never cleared, that isn't that much of a problem since it is overriden anyways 2) The condition to check if clearing should happen was always true since it compared the clippedText member variable with itself. The clippedText variables that are create above the condition are out of scope. I fixed these bugs and clear both clipboard types if they contain the given text, ignoring the setting, which should make it more robust.
annejan merged commit
Mar 14, 2018
4 of 5 checks passed
4 of 5 checks passed
codecov/patch 0% of diff hit (target 2.92%)Details
codecov/project 2.92% (+<.01%) compared to baf5ea8Details
continuous-integration/appveyor/pr AppVeyor build succeededDetails
continuous-integration/travis-ci/pr The Travis CI build passedDetails
linthub Linthub has cleared the pull request, no code style suggestions found.Details
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.