-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix & make clearClipboard more robust #359
Conversation
Codecov Report
@@ Coverage Diff @@
## master #359 +/- ##
=========================================
+ Coverage 2.92% 2.92% +<.01%
=========================================
Files 36 36
Lines 2699 2698 -1
Branches 360 361 +1
=========================================
Hits 79 79
+ Misses 2619 2618 -1
Partials 1 1
Continue to review full report at Codecov.
|
The current version had 2 bugs: 1) The clippedText was never cleared, that isn't that much of a problem since it is overriden anyways 2) The condition to check if clearing should happen was always true since it compared the clippedText member variable with itself. The clippedText variables that are create above the condition are out of scope. I fixed these bugs and clear both clipboard types if they contain the given text, ignoring the setting, which should make it more robust.
I'll rebase to fix the conflicts |
f921898
to
9e3d0d3
Compare
When the template is not used the passdialog still showed the template fields. With this commit the setting is properly respected.
I have some more changes I will want to commit. Should I just create a new PR? Or append here? |
Appending here is fine by me @lukedirtwalker |
@annejan added some more commits, they don't really have to do with the initial fix. I think it is best to review commit by commit. |
I will later tonight . . |
The current version had 2 bugs:
since it is overriden anyways
since it compared the clippedText member variable with itself. The
clippedText variables that are create above the condition are out of
scope.
I fixed these bugs and clear both clipboard types if they contain the
given text, ignoring the setting, which should make it more robust.