Fix & make clearClipboard more robust - #359
Merged
Merged
Conversation
annejan
self-requested a review
March 12, 2018 15:10
Codecov Report
@@ Coverage Diff @@
## master #359 +/- ##
=========================================
+ Coverage 2.92% 2.92% +<.01%
=========================================
Files 36 36
Lines 2699 2698 -1
Branches 360 361 +1
=========================================
Hits 79 79
+ Misses 2619 2618 -1
Partials 1 1
Continue to review full report at Codecov.
|
The current version had 2 bugs: 1) The clippedText was never cleared, that isn't that much of a problem since it is overriden anyways 2) The condition to check if clearing should happen was always true since it compared the clippedText member variable with itself. The clippedText variables that are create above the condition are out of scope. I fixed these bugs and clear both clipboard types if they contain the given text, ignoring the setting, which should make it more robust.
Contributor
Author
|
I'll rebase to fix the conflicts |
lukedirtwalker
force-pushed
the
fixClipboardClear
branch
from
March 12, 2018 15:25
f921898 to
9e3d0d3
Compare
When the template is not used the passdialog still showed the template fields. With this commit the setting is properly respected.
Contributor
Author
|
I have some more changes I will want to commit. Should I just create a new PR? Or append here? |
Member
|
Appending here is fine by me @lukedirtwalker |
Contributor
Author
|
@annejan added some more commits, they don't really have to do with the initial fix. I think it is best to review commit by commit. |
Member
|
I will later tonight . . |
annejan
approved these changes
Mar 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current version had 2 bugs:
since it is overriden anyways
since it compared the clippedText member variable with itself. The
clippedText variables that are create above the condition are out of
scope.
I fixed these bugs and clear both clipboard types if they contain the
given text, ignoring the setting, which should make it more robust.