Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning #includes #364

Merged
merged 2 commits into from Apr 18, 2018
Merged

Cleaning #includes #364

merged 2 commits into from Apr 18, 2018

Conversation

FiloSpaTeam
Copy link
Contributor

@FiloSpaTeam FiloSpaTeam commented Apr 18, 2018

Goals:

  • Faster compilation
  • Remove unused or recursive headers
  • Now refactor code is simpler

@annejan
Copy link
Member

annejan commented Apr 18, 2018

Checking this out ASAP

@FiloSpaTeam
Copy link
Contributor Author

Don't worry 👍
http://www.bartvermijlen.com/4-reasons-why-you-should-stop-using-the-word-asap/

@codecov
Copy link

codecov bot commented Apr 18, 2018

Codecov Report

Merging #364 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #364      +/-   ##
=========================================
+ Coverage    6.34%   6.35%   +<.01%     
=========================================
  Files          39      39              
  Lines        2710    2707       -3     
  Branches      355     355              
=========================================
  Hits          172     172              
+ Misses       2532    2529       -3     
  Partials        6       6
Impacted Files Coverage Δ
src/trayicon.cpp 0% <ø> (ø) ⬆️
src/passworddialog.cpp 74.66% <ø> (ø) ⬆️
src/mainwindow.h 0% <ø> (ø) ⬆️
src/trayicon.h 0% <ø> (ø) ⬆️
src/qtpasssettings.h 0% <ø> (ø) ⬆️
src/mainwindow.cpp 0% <ø> (ø) ⬆️
src/qtpasssettings.cpp 2.81% <ø> (ø) ⬆️
src/storemodel.cpp 0% <ø> (ø) ⬆️
src/usersdialog.h 0% <ø> (ø) ⬆️
src/keygendialog.cpp 0% <ø> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de84470...386faf1. Read the comment docs.

@coveralls
Copy link

coveralls commented Apr 18, 2018

Coverage Status

Coverage increased (+0.003%) to 6.269% when pulling 386faf1 on UnitooTeam:master into de84470 on IJHack:master.

Copy link
Member

@annejan annejan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I don't like the commenting out of #includes
Will remove them after merge ;)

@annejan annejan merged commit 39b5ef4 into IJHack:master Apr 18, 2018
@FiloSpaTeam
Copy link
Contributor Author

Oh sorry, i clean up 👍

@annejan
Copy link
Member

annejan commented Apr 18, 2018

No worries, merged, already on it :-)

This is something nice to do in the sun today 🌞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants