Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes and refactoring. #376

Merged
merged 5 commits into from Apr 28, 2018
Merged

Some fixes and refactoring. #376

merged 5 commits into from Apr 28, 2018

Conversation

@FiloSpaTeam
Copy link
Contributor

@FiloSpaTeam FiloSpaTeam commented Apr 28, 2018

I tryied a big refactoring but first we need to clean up classes from duplicated code or similar code.

@annejan annejan self-requested a review Apr 28, 2018
@annejan annejan self-assigned this Apr 28, 2018
@codecov
Copy link

@codecov codecov bot commented Apr 28, 2018

Codecov Report

Merging #376 into master will increase coverage by 0.22%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #376      +/-   ##
=========================================
+ Coverage    6.25%   6.48%   +0.22%     
=========================================
  Files          39      39              
  Lines        2684    2590      -94     
  Branches      347     341       -6     
=========================================
  Hits          168     168              
+ Misses       2510    2416      -94     
  Partials        6       6
Impacted Files Coverage Δ
src/mainwindow.h 0% <ø> (ø) ⬆️
src/configdialog.h 0% <ø> (ø) ⬆️
src/configdialog.cpp 0% <0%> (ø) ⬆️
src/mainwindow.cpp 0% <0%> (ø) ⬆️
src/passworddialog.cpp 58.58% <0%> (-0.6%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7c6249...627c1ea. Read the comment docs.

@coveralls
Copy link

@coveralls coveralls commented Apr 28, 2018

Coverage Status

Coverage increased (+0.1%) to 6.357% when pulling 627c1ea on UnitooTeam:master into b7c6249 on IJHack:master.

1 similar comment
@coveralls
Copy link

@coveralls coveralls commented Apr 28, 2018

Coverage Status

Coverage increased (+0.1%) to 6.357% when pulling 627c1ea on UnitooTeam:master into b7c6249 on IJHack:master.

@annejan annejan merged commit f691095 into IJHack:master Apr 28, 2018
5 of 6 checks passed
5 of 6 checks passed
codecov/patch 0% of diff hit (target 6.25%)
Details
CodeFactor 1 issue fixed.
Details
codecov/project 6.48% (+0.22%) compared to b7c6249
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
linthub Linthub has cleared the pull request, no code style suggestions found.
Details
@annejan
Copy link
Member

@annejan annejan commented Apr 28, 2018

I really love all the work you are doing here!

@FiloSpaTeam
Copy link
Contributor Author

@FiloSpaTeam FiloSpaTeam commented Apr 28, 2018

i like hack with code :) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants