Some fixes and refactoring. #376
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #376 +/- ##
=========================================
+ Coverage 6.25% 6.48% +0.22%
=========================================
Files 39 39
Lines 2684 2590 -94
Branches 347 341 -6
=========================================
Hits 168 168
+ Misses 2510 2416 -94
Partials 6 6
Continue to review full report at Codecov.
|
1 similar comment
f691095
into
IJHack:master
5 of 6 checks passed
5 of 6 checks passed
I really love all the work you are doing here! |
i like hack with code :) :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I tryied a big refactoring but first we need to clean up classes from duplicated code or similar code.