New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pwgen: fix inverted "Generate ... less secure passwords" checkbox #409

Merged
merged 1 commit into from Aug 6, 2018

Conversation

Projects
None yet
3 participants
@ahippo
Contributor

ahippo commented Aug 5, 2018

Checking the checkbox "Generate easy to memorize but less secure passwords"
(aka isLessRandom())
means omitting "--secure" option to pwgen.
Unchecking the checkbox means passing "--secure" option to pwgen,
which is meant to be the default for QtPass.

This got broken in
b11e71d Use new executor in Pass

Fix this by inverting the check once again.

pwgen: fix inverted "Generate ... less secure passwords" checkbox
Checking the checkbox "Generate easy to memorize but less secure passwords"
(aka `isLessRandom()`)
means _omitting_ "--secure" option to `pwgen`.
Unchecking the checkbox means _passing_ "--secure" option to `pwgen`,
which is meant to be the default for QtPass.

This got broken in
b11e71d Use new executor in Pass

Fix this by inverting the check once again.
@codecov

This comment has been minimized.

codecov bot commented Aug 5, 2018

Codecov Report

Merging #409 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #409   +/-   ##
======================================
  Coverage    6.46%   6.46%           
======================================
  Files          39      39           
  Lines        2585    2585           
======================================
  Hits          167     167           
  Misses       2418    2418
Impacted Files Coverage Δ
src/pass.cpp 2.56% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f06313e...23962c9. Read the comment docs.

@coveralls

This comment has been minimized.

coveralls commented Aug 5, 2018

Coverage Status

Coverage increased (+0.1%) to 6.503% when pulling 23962c9 on ahippo:pwgen-secure into f06313e on IJHack:master.

@annejan annejan merged commit fd56323 into IJHack:master Aug 6, 2018

5 of 6 checks passed

codecov/patch 0% of diff hit (target 6.46%)
Details
CodeFactor No issues found.
Details
codecov/project 6.46% remains the same compared to f06313e
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
linthub Linthub has cleared the pull request, no code style suggestions found.
Details
@ahippo

This comment has been minimized.

Contributor

ahippo commented Aug 6, 2018

Thank you for merging this so quickly!

@ahippo ahippo deleted the ahippo:pwgen-secure branch Aug 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment