Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semi-automatic code cleanup #425

Merged
merged 14 commits into from Apr 18, 2019

Conversation

Projects
None yet
2 participants
@annejan
Copy link
Member

commented Oct 24, 2018

Using clang-tidy, clang-format and clazy

This might break compatibility with older linux distro's . .

annejan added some commits Oct 11, 2018

@annejan annejan added the refactoring label Oct 24, 2018

@annejan annejan self-assigned this Oct 24, 2018

@codecov

This comment has been minimized.

Copy link

commented Oct 24, 2018

Codecov Report

Merging #425 into master will decrease coverage by <.01%.
The diff coverage is 4.1%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #425      +/-   ##
=========================================
- Coverage    7.13%   7.13%   -0.01%     
=========================================
  Files          43      44       +1     
  Lines        2775    2776       +1     
=========================================
  Hits          198     198              
- Misses       2577    2578       +1
Impacted Files Coverage Δ
src/pass.cpp 4.61% <ø> (ø) ⬆️
src/qpushbuttonasqrcode.h 0% <ø> (ø) ⬆️
src/settingsconstants.cpp 100% <ø> (+1.88%) ⬆️
src/singleapplication.h 0% <ø> (ø) ⬆️
src/keygendialog.h 0% <ø> (ø) ⬆️
src/trayicon.h 0% <ø> (ø) ⬆️
src/imitatepass.h 40% <ø> (+15%) ⬆️
src/mainwindow.cpp 0% <0%> (ø) ⬆️
src/singleapplication.cpp 0% <0%> (ø) ⬆️
src/configdialog.cpp 0% <0%> (ø) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0789259...d483e98. Read the comment docs.

@coveralls

This comment has been minimized.

Copy link

commented Oct 24, 2018

Coverage Status

Coverage increased (+0.06%) to 7.321% when pulling 757f115 on clang-tidy-clazy into 32ea1ad on master.

@coveralls

This comment has been minimized.

Copy link

commented Oct 24, 2018

Coverage Status

Coverage decreased (-0.1%) to 7.024% when pulling d483e98 on clang-tidy-clazy into 0789259 on master.

annejan added some commits Nov 13, 2018

@annejan annejan merged commit 5759b50 into master Apr 18, 2019

4 of 7 checks passed

CodeFactor 1 issue found.
Details
codecov/patch 4.1% of diff hit (target 7.13%)
Details
codecov/project 7.13% (-0.01%) compared to 0789259
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.